reject a table redefined after its parent table header#516
Open
netliomax25-code wants to merge 1 commit into
Open
reject a table redefined after its parent table header#516netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Container.appendsends a concrete[table]header that lands inside an existing implicit/super table through_validate_table_candidate, which only flagged a child key on a type change or a dotted-key redefinition.[a.b]/[a]/[a.b], and the deeper[a.b.c]/[a]/[a.b.c]) was merged silently instead of rejected, whiletomlliband the toml-test suite treat these as declaring the same table twice._validate_table_candidatenow raises when the existing child and the candidate child are both concrete (non-super) tables, and recurses through matching super tables so a duplicate nested deeper is caught as well. Valid out-of-order tables (a new sibling subtable, or extending a table with a deeper header) keep parsing, and the existing tests plus the toml-test 1.0/1.1 suites pass.Agent Drafting Metadata