Clarify run_process Ctrl+C documentation - #3486
Madhur-7568 wants to merge 1 commit into
Conversation
|
Hi, I just wanted to check if you have any feedback or suggestions for this pr. |
|
Thanks! To be honest, since I don't really know how the issue should be fixed, I think this is fine. But I have some quibbles about wording: I actually preferred the old wording! However, I think mentioning the relevant args is a good idea. Sorry about the delay xd |
Hi, I recently opened PR #3512 in Trio to expose AsyncIOWrapper publicly and add the related typing tests and documentation. I’m still fairly new to contributing to larger open-source projects, so I wanted to reach out and ask if you would be willing to take a look when you have some time. I’d especially appreciate any feedback on the API/export approach or anything you think should be changed before it’s ready and if not merged tell me why so i can learn from it . PR: #3512 There’s currently one failing macOS 3.15-dev CI job, but from the logs it looks like the Python setup failed because of a GitHub/DNS issue before the tests actually ran. The other checks were completed successfully. No rush at all , I mainly wanted to make sure the PR reaches someone familiar with the project. Thanks for your time, |
Summary
Clarify the
run_processdocumentation around Ctrl+C behavior.The note now explains that child processes normally receive Ctrl+C along with the parent process. It also points readers to Python's
process_groupandstart_new_sessionoptions for cases where different behavior is needed.Closes #3300