Skip to content

Feat/1293 download dispatch - #1338

Open
LalatenduMohanty wants to merge 1 commit into
python-wheel-build:new-resolver-configfrom
LalatenduMohanty:feat/1293-download-dispatch
Open

LalatenduMohanty wants to merge 1 commit into
python-wheel-build:new-resolver-configfrom
LalatenduMohanty:feat/1293-download-dispatch

Conversation

@LalatenduMohanty

Copy link
Copy Markdown
Member

Pull Request Description

Route configured source downloads through their resolver so the download boundary exposes artifact kinds to later phases while preserving legacy package behavior.

Closes #1293

@LalatenduMohanty
LalatenduMohanty requested a review from a team as a code owner September 18, 2026 22:16
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: python-wheel-build/fromager/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 98e520fd-7c33-4d06-95e1-f7c020125202

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LalatenduMohanty
LalatenduMohanty changed the base branch from main to new-resolver-config September 18, 2026 22:16
@mergify mergify Bot added the ci label Sep 18, 2026
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1293-download-dispatch branch from b777a35 to 73a31b2 Compare September 18, 2026 22:37
@LalatenduMohanty
LalatenduMohanty marked this pull request as draft September 18, 2026 22:37
@LalatenduMohanty
LalatenduMohanty marked this pull request as ready for review September 21, 2026 14:58
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1293-download-dispatch branch 3 times, most recently from 6a75732 to ccc670f Compare September 21, 2026 20:53
When a package has a `source:` resolver configured, delegate
`download_source()` to `source_resolver.download()` instead of the
legacy override-hook path.  Change the return type from `Path` to
`(Path, DownloadKind)` so callers know what artifact was downloaded
(sdist, tarball, prebuilt wheel, or git checkout).

Also implement `resolver_provider()` for the `hook-sdist` and
`hook-prebuilt` resolver profiles, which invoke the package's
`get_resolver_provider` override hook and validate the result.

Closes: python-wheel-build#1293
Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1293-download-dispatch branch from ccc670f to ef28435 Compare September 21, 2026 21:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add source_resolver dispatch to download pipeline

1 participant