Skip to content

Add git gc step to the end of every build #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zware merged 2 commits into from
Sep 13, 2026
Merged

Add git gc step to the end of every build #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b25911
Remove unused CleanupTest step definition
zware Sep 10, 2026
f8e1415
Add a 'git gc' step at the end of every build
zware Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions master/custom/steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,18 @@ class GitHub(_GitHub):
warnOnFailure = True


class GitGC(ShellCommand):
name = 'git-gc'
warnOnFailure = True
haltOnFailure = False
flunkOnFailure = False
alwaysRun = True

description = ["cleaning git checkout"]
descriptionDone = ["git garbage collected"]
command = ["git", "gc"]


class Test(BaseTest):
# Regular expression used to catch warnings, errors and bugs
warningPattern = (
Expand Down Expand Up @@ -144,14 +156,6 @@ class Clean(ShellCommand):
alwaysRun = True


class CleanupTest(ShellCommand):
name = "cleantest"
description = ["cleaning previous tests"]
descriptionDone = ["clean previous tests"]
flunkOnFailure = False
warnOnFailure = True


class Install(ShellCommand):
name = "install"
description = ["installing"]
Expand Down
5 changes: 4 additions & 1 deletion master/master.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ from custom.pr_testing import ( # noqa: E402
should_pr_be_tested,
)
from custom.settings import Settings # noqa: E402
from custom.steps import Git, GitHub # noqa: E402
from custom.steps import GitGC, GitHub # noqa: E402
from custom.workers import get_workers # noqa: E402
from custom.schedulers import GitHubPrScheduler # noqa: E402
from custom.release_dashboard import get_release_status_app # noqa: E402
Expand Down Expand Up @@ -226,6 +226,9 @@ for branch in BRANCHES:
if branch not in f.branches:
continue

# Stopgap space saver until blobless clones are fixed (buildbot 4.4+)
f.addStep(GitGC())

tags = [branch.builder_tag, *builder_def.tags, *f.tags]

if 'nogil' in tags and branch.gil_only:
Expand Down