gh-140389: fixed touchpad horizontal scrolling in IDLE editor - #140390
TheLizzard wants to merge 5 commits into
Conversation
|
Sorry for the typos I made in the tests I created and wasting GitHub resources. I was sure I ran them but I must have screwed up. Fixed them now and they should work. |
StanFromIreland
left a comment
There was a problem hiding this comment.
I can confirm with manual testing that the patch does implement horizontal scrolling with a touchpad on Unix.
|
This PR is stale because it has been open for 30 days with no activity. |
wheel_event() and its tests moved from idlelib.tree to idlelib.util in pythonGH-156974, so the horizontal scrolling change is re-applied there.
|
I merged main into this branch to resolve the conflicts: gh-154511 (GH-156974) moved For the record, the Shift check is enough on every Tk we support: Tk 9 reports horizontal scrolling as I have no strong opinion about this feature, but no objections either. I leave the decision to @terryjreedy. |
Description
IDLE doesn't have a horizontal scrollbar but that shouldn't stop the user from using their trackpad/touchpad to horizontally scroll the text. This is a small bug that can sometimes annoy people
Previously
If you try to scroll horizontally using a trackpad/touchpad, the text in IDLE would scroll vertically.
Summary of changes
<tkinter.Event>.state)Testing
I tested the issue and the fix on: Windows 11, Ubuntu 24.04 and Debian 13. The issue appears on all OSes and the fix works on all of them. While I am not 100% sure if this will break on MacOS, I am very confident that there will be no problems.
Fixes #140389