Skip to content

gh-156784: unignore error port unreachable in proactor - #156788

Open
graingert wants to merge 12 commits into
python:mainfrom
graingert:unignore-error-port-unreachable-in-proactor
Open

gh-156784: unignore error port unreachable in proactor #156788
graingert wants to merge 12 commits into
python:mainfrom
graingert:unignore-error-port-unreachable-in-proactor

Conversation

@graingert

@graingert graingert commented Sep 1, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Sep 1, 2026
Open
@graingert

graingert commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

This PR depends on two other PRs: #156726 and #156718

@esoma

esoma commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

fwiw as the author of #32011 this change makes sense to me. I thought I'd had a conversation with someone on whether to suppress the error getting reported or not, but I can't seem to find it.

For some context, prior to #32011 it would have been reported to the transport's error_received as an OSError.

@graingert
Merge branch 'main' into fix-proactor-error-hang
60187dd
@graingert
fix DatagramTransport when errror_recieved calls sendto
d57cb23
@graingert
Merge branch 'main' of github.com:python/cpython into fix-proactor-er…
bb80478 
…ror-hang

# Conflicts:
#	Lib/test/test_asyncio/test_events.py
@graingert
Merge branch 'fix-proactor-error-hang' into unignore-error-port-unrea…
99dd5a1 
…chable-in-proactor

# Conflicts:
#	Misc/NEWS.d/next/Library/2026-08-31-00-00-00.gh-issue-127057.N9yg62.rst
@graingert
Merge branch 'main' of github.com:python/cpython into unignore-error-…
bad71a2 
…port-unreachable-in-proactor

# Conflicts:
#	Lib/asyncio/proactor_events.py
#	Lib/test/test_asyncio/test_events.py
graingert
graingert commented Sep 16, 2026
View reviewed changes
Comment thread Lib/asyncio/proactor_events.py Outdated
graingert
graingert commented Sep 16, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-09-01-00-00-00.gh-issue-156784.8gvtt4.rst Outdated
@graingert
graingert marked this pull request as ready for review September 16, 2026 09:29
@graingert graingert added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

awaiting review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The fix in gh-91227 is incorrect, the SelectorEventLoop has the correct behaviour calling error_received and continuing to run the Transport

2 participants

@graingert @esoma