[types] Make MethodType generic - #15993
Open
srittau wants to merge 16 commits into
Open
Conversation
Collaborator
Author
|
Will be useful for #15977. |
This comment has been minimized.
This comment has been minimized.
srittau
marked this pull request as ready for review
July 10, 2026 12:40
This comment has been minimized.
This comment has been minimized.
| def __qualname__(self) -> str: ... # inherited from the added function | ||
| def __new__(cls, func: Callable[..., Any], instance: object, /) -> Self: ... | ||
| def __call__(self, *args: Any, **kwargs: Any) -> Any: ... | ||
| def __new__(cls, func: Callable[_P_default, _R_default], instance: object, /) -> Self: ... |
Member
There was a problem hiding this comment.
I think this isn't correct, it doesn't account for the fact that the self argument is bound. We may need to Concatenate a parameter that matches instance in type.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pydantic (https://github.com/pydantic/pydantic)
- pydantic/experimental/arguments_schema.py:41: error: Argument 1 to "_arguments_schema" of "GenerateSchema" has incompatible type "Callable[..., Any]"; expected "FunctionType | MethodType | partial[Any]" [arg-type]
+ pydantic/experimental/arguments_schema.py:41: error: Argument 1 to "_arguments_schema" of "GenerateSchema" has incompatible type "Callable[..., Any]"; expected "FunctionType | MethodType[[VarArg(Any), KwArg(Any)], Any] | partial[Any]" [arg-type]
- pydantic/experimental/arguments_schema.py:43: error: Argument 1 to "_arguments_v3_schema" of "GenerateSchema" has incompatible type "Callable[..., Any]"; expected "FunctionType | MethodType | partial[Any]" [arg-type]
+ pydantic/experimental/arguments_schema.py:43: error: Argument 1 to "_arguments_v3_schema" of "GenerateSchema" has incompatible type "Callable[..., Any]"; expected "FunctionType | MethodType[[VarArg(Any), KwArg(Any)], Any] | partial[Any]" [arg-type]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.