Skip to content

Fix broken fbcode//executorch/backends/apple/mps:test - test_emformer (execut (#20432)#20432

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
jansel:export-D109012812
Jun 24, 2026
Merged

Fix broken fbcode//executorch/backends/apple/mps:test - test_emformer (execut (#20432)#20432
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
jansel:export-D109012812

Conversation

@jansel

@jansel jansel commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary: Pull Request resolved: #20432

Reviewed By: angelayi

Differential Revision: D109012812

Copilot AI review requested due to automatic review settings June 22, 2026 17:36
@pytorch-bot

pytorch-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20432

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 3 Unrelated Failures

As of commit 7e3d53e with merge base aada6d7 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2026
@meta-codesync

meta-codesync Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@jansel has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109012812.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a failure when adjusting an ExportedProgram after delegation/lowering by making deletions from the program’s internal state dict/constants table tolerant to missing keys (avoiding KeyError during cleanup).

Changes:

  • Replace del with dict.pop(key, None) when removing consumed parameters from original_program._state_dict.
  • Replace del with dict.pop(key, None) when removing consumed non-persistent buffers / constant tensors from original_program._constants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meta-codesync meta-codesync Bot changed the title Fix broken fbcode//executorch/backends/apple/mps:test - test_emformer (execut Fix broken fbcode//executorch/backends/apple/mps:test - test_emformer (execut (#20432) Jun 23, 2026
@jansel jansel force-pushed the export-D109012812 branch from a6245c5 to d32d90f Compare June 23, 2026 00:59
jansel added a commit to jansel/executorch that referenced this pull request Jun 23, 2026
… (execut (pytorch#20432)

Summary: Pull Request resolved: pytorch#20432

Reviewed By: angelayi

Differential Revision: D109012812
jansel added a commit to jansel/executorch that referenced this pull request Jun 23, 2026
… (execut (pytorch#20432)

Summary: Pull Request resolved: pytorch#20432

Reviewed By: angelayi

Differential Revision: D109012812
@jansel jansel force-pushed the export-D109012812 branch from d32d90f to 7a0a7be Compare June 23, 2026 01:00
jansel added a commit to jansel/executorch that referenced this pull request Jun 23, 2026
… (execut (pytorch#20432)

Summary: Pull Request resolved: pytorch#20432

Reviewed By: angelayi

Differential Revision: D109012812
Copilot AI review requested due to automatic review settings June 23, 2026 05:32
@jansel jansel force-pushed the export-D109012812 branch from 7a0a7be to 7b3c7f6 Compare June 23, 2026 05:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment on lines +972 to +976
# First pass: identify placeholder nodes that still have users in the graph.
# These cannot be deleted because they are shared between the delegate and
# the remaining program (e.g., due to identity ops like no-op dropout
# causing parameter aliasing across partitions).
nodes_to_keep = set()
@jansel jansel force-pushed the export-D109012812 branch from 7b3c7f6 to ec40727 Compare June 23, 2026 23:35
jansel added a commit to jansel/executorch that referenced this pull request Jun 23, 2026
… (execut (pytorch#20432)

Summary: Pull Request resolved: pytorch#20432

Reviewed By: angelayi

Differential Revision: D109012812
… (execut (pytorch#20432)

Summary: Pull Request resolved: pytorch#20432

Reviewed By: angelayi

Differential Revision: D109012812
@jansel jansel force-pushed the export-D109012812 branch from ec40727 to 7e3d53e Compare June 23, 2026 23:42
@meta-codesync meta-codesync Bot merged commit 1621fa2 into pytorch:main Jun 24, 2026
175 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants