Fix broken fbcode//executorch/backends/apple/mps:test - test_emformer (execut (#20432)#20432
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20432
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 3 Unrelated FailuresAs of commit 7e3d53e with merge base aada6d7 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@jansel has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109012812. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a failure when adjusting an ExportedProgram after delegation/lowering by making deletions from the program’s internal state dict/constants table tolerant to missing keys (avoiding KeyError during cleanup).
Changes:
- Replace
delwithdict.pop(key, None)when removing consumed parameters fromoriginal_program._state_dict. - Replace
delwithdict.pop(key, None)when removing consumed non-persistent buffers / constant tensors fromoriginal_program._constants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a6245c5 to
d32d90f
Compare
… (execut (pytorch#20432) Summary: Pull Request resolved: pytorch#20432 Reviewed By: angelayi Differential Revision: D109012812
… (execut (pytorch#20432) Summary: Pull Request resolved: pytorch#20432 Reviewed By: angelayi Differential Revision: D109012812
d32d90f to
7a0a7be
Compare
… (execut (pytorch#20432) Summary: Pull Request resolved: pytorch#20432 Reviewed By: angelayi Differential Revision: D109012812
7a0a7be to
7b3c7f6
Compare
| # First pass: identify placeholder nodes that still have users in the graph. | ||
| # These cannot be deleted because they are shared between the delegate and | ||
| # the remaining program (e.g., due to identity ops like no-op dropout | ||
| # causing parameter aliasing across partitions). | ||
| nodes_to_keep = set() |
7b3c7f6 to
ec40727
Compare
… (execut (pytorch#20432) Summary: Pull Request resolved: pytorch#20432 Reviewed By: angelayi Differential Revision: D109012812
… (execut (pytorch#20432) Summary: Pull Request resolved: pytorch#20432 Reviewed By: angelayi Differential Revision: D109012812
ec40727 to
7e3d53e
Compare
Summary: Pull Request resolved: #20432
Reviewed By: angelayi
Differential Revision: D109012812