Skip to content

[ExecuTorch][WebGPU] Flatten landed-op test dirs to test/ops/test_<op>.py#20435

Open
JulianCloudNTH wants to merge 3 commits into
gh/JulianCloudNTH/50/basefrom
gh/JulianCloudNTH/50/head
Open

[ExecuTorch][WebGPU] Flatten landed-op test dirs to test/ops/test_<op>.py#20435
JulianCloudNTH wants to merge 3 commits into
gh/JulianCloudNTH/50/basefrom
gh/JulianCloudNTH/50/head

Conversation

@JulianCloudNTH

@JulianCloudNTH JulianCloudNTH commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Pure test-file relocation: moves the already-landed ops' tests from nested test/ops/<op>/test_<op>.py to flat test/ops/test_<op>.py, matching the ExecuTorch convention (XNNPACK uses flat test/ops/test_<op>.py; Vulkan uses flat test/test_*.py) and completing the flatten applied to the new ops in the stack below. Drops the per-op __init__.py; the parent test/ops/__init__.py is kept. Ops: add, rms_norm, sdpa (test_sdpa + test_update_cache), dispatch_order, quantized_linear, embedding_q4gsw, rope, prepack.

No behavior change — the test modules and their export/golden functions are unchanged; only their path moves. Every reference to the old paths is updated: the cases.py op-test imports (add, rms_norm), test/TARGETS (test_add srcs), test/ops/test_dispatch_order.py's internal rms_norm import, and the build/CI scripts that import the per-op export functions (test/test_build_webgpu.sh, scripts/test_webgpu_native_ci.sh).

Nothing required the per-op subdirectory: the codegen framework imports only cases.py, the one buck target uses a literal path, and the native-golden scripts import the modules by path — each resolves identically at the flat path.
@exported-using-ghexport

Differential Revision: D109349894

Differential Revision: D109349894

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20435

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 4 Unrelated Failures

As of commit 1002b80 with merge base 65bc0ca (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]
[ghstack-poisoned]
JulianCloudNTH added a commit that referenced this pull request Jun 23, 2026
…>.py

Pull Request resolved: #20435

Pure test-file relocation: moves the already-landed ops' tests from nested `test/ops/<op>/test_<op>.py` to flat `test/ops/test_<op>.py`, matching the ExecuTorch convention (XNNPACK uses flat `test/ops/test_<op>.py`; Vulkan uses flat `test/test_*.py`) and completing the flatten applied to the new ops in the stack below. Drops the per-op `__init__.py`; the parent `test/ops/__init__.py` is kept. Ops: `add`, `rms_norm`, `sdpa` (`test_sdpa` + `test_update_cache`), `dispatch_order`, `quantized_linear`, `embedding_q4gsw`, `rope`, `prepack`.

No behavior change — the test modules and their export/golden functions are unchanged; only their path moves. Every reference to the old paths is updated: the `cases.py` op-test imports (`add`, `rms_norm`), `test/TARGETS` (`test_add` srcs), `test/ops/test_dispatch_order.py`'s internal `rms_norm` import, and the build/CI scripts that import the per-op export functions (`test/test_build_webgpu.sh`, `scripts/test_webgpu_native_ci.sh`).

Nothing required the per-op subdirectory: the codegen framework imports only `cases.py`, the one buck target uses a literal path, and the native-golden scripts import the modules by path — each resolves identically at the flat path.
ghstack-source-id: 396310740
@exported-using-ghexport

Differential Revision: [D109349894](https://our.internmc.facebook.com/intern/diff/D109349894/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants