[ExecuTorch][WebGPU] Flatten landed-op test dirs to test/ops/test_<op>.py#20435
[ExecuTorch][WebGPU] Flatten landed-op test dirs to test/ops/test_<op>.py#20435JulianCloudNTH wants to merge 3 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20435
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 4 Unrelated FailuresAs of commit 1002b80 with merge base 65bc0ca ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
…>.py Pull Request resolved: #20435 Pure test-file relocation: moves the already-landed ops' tests from nested `test/ops/<op>/test_<op>.py` to flat `test/ops/test_<op>.py`, matching the ExecuTorch convention (XNNPACK uses flat `test/ops/test_<op>.py`; Vulkan uses flat `test/test_*.py`) and completing the flatten applied to the new ops in the stack below. Drops the per-op `__init__.py`; the parent `test/ops/__init__.py` is kept. Ops: `add`, `rms_norm`, `sdpa` (`test_sdpa` + `test_update_cache`), `dispatch_order`, `quantized_linear`, `embedding_q4gsw`, `rope`, `prepack`. No behavior change — the test modules and their export/golden functions are unchanged; only their path moves. Every reference to the old paths is updated: the `cases.py` op-test imports (`add`, `rms_norm`), `test/TARGETS` (`test_add` srcs), `test/ops/test_dispatch_order.py`'s internal `rms_norm` import, and the build/CI scripts that import the per-op export functions (`test/test_build_webgpu.sh`, `scripts/test_webgpu_native_ci.sh`). Nothing required the per-op subdirectory: the codegen framework imports only `cases.py`, the one buck target uses a literal path, and the native-golden scripts import the modules by path — each resolves identically at the flat path. ghstack-source-id: 396310740 @exported-using-ghexport Differential Revision: [D109349894](https://our.internmc.facebook.com/intern/diff/D109349894/)
Stack from ghstack (oldest at bottom):
Pure test-file relocation: moves the already-landed ops' tests from nested
test/ops/<op>/test_<op>.pyto flattest/ops/test_<op>.py, matching the ExecuTorch convention (XNNPACK uses flattest/ops/test_<op>.py; Vulkan uses flattest/test_*.py) and completing the flatten applied to the new ops in the stack below. Drops the per-op__init__.py; the parenttest/ops/__init__.pyis kept. Ops:add,rms_norm,sdpa(test_sdpa+test_update_cache),dispatch_order,quantized_linear,embedding_q4gsw,rope,prepack.No behavior change — the test modules and their export/golden functions are unchanged; only their path moves. Every reference to the old paths is updated: the
cases.pyop-test imports (add,rms_norm),test/TARGETS(test_addsrcs),test/ops/test_dispatch_order.py's internalrms_normimport, and the build/CI scripts that import the per-op export functions (test/test_build_webgpu.sh,scripts/test_webgpu_native_ci.sh).Nothing required the per-op subdirectory: the codegen framework imports only
cases.py, the one buck target uses a literal path, and the native-golden scripts import the modules by path — each resolves identically at the flat path.@exported-using-ghexport
Differential Revision: D109349894
Differential Revision: D109349894