Fix grouped conv1d conversion after decomposition - #22213
Open
zingo wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22213
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
zingo
added
release notes: arm
Collaborator
Author
rascani
approved these changes
Aug 27, 2026
zingo
force-pushed
the
Fix-grouped-Conv1d-conversion-after-decomposition
branch
from
August 28, 2026 08:13
1b7afa7 to
e5e6d2d
Compare
Allow callers to configure graph-local weight producers that are safe to convert. Configure Arm to accept the weight slices created by grouped convolution decomposition. Fix test_conv1d_groups for the arm_tosa_fp and arm_tosa_int flows. Add TOSA FP and INT coverage for per-tensor and per-channel quantization. Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com> Change-Id: I584a9936228eb68037641bc662d61a0811025a39
zingo
force-pushed
the
Fix-grouped-Conv1d-conversion-after-decomposition
branch
from
August 28, 2026 10:58
e5e6d2d to
e161555
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow callers to configure graph-local weight producers that are safe
to convert. Configure Arm to accept the weight slices created by
grouped convolution decomposition.
Fix test_conv1d_groups for the arm_tosa_fp and arm_tosa_int flows. Add
TOSA FP and INT coverage for per-tensor and per-channel quantization.
cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani