Skip redundant recompile in identical-input transform fusion (#22217) - #22217
Skip redundant recompile in identical-input transform fusion (#22217)#22217apullin wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22217
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 31cb628 with merge base d58fc25 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@apullin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114790128. |
This PR needs a
|
…#22217) Summary: Skip redundant recompile in identical-input transform fusion. Remove redundant GraphModule.recompile() immediately before super().call() in FuseIdenticalInputTransformsPass. Pass already eliminates dead code and lints before handing to ARM framework for retracing. Recompiling Python GraphModule at that point is unnecessary because ExportPass call reconstructs/interprets graph rather than relying on just-compiled code object. Behavior-preserving speedup. Differential Revision: D114790128
93ed924 to
8edbba0
Compare
…#22217) Summary: Skip redundant recompile in identical-input transform fusion. Remove redundant GraphModule.recompile() immediately before super().call() in FuseIdenticalInputTransformsPass. Pass already eliminates dead code and lints before handing to ARM framework for retracing. Recompiling Python GraphModule at that point is unnecessary because ExportPass call reconstructs/interprets graph rather than relying on just-compiled code object. Behavior-preserving speedup. Differential Revision: D114790128
8edbba0 to
611fdc1
Compare
…#22217) Summary: Skip redundant recompile in identical-input transform fusion. Remove redundant GraphModule.recompile() immediately before super().call() in FuseIdenticalInputTransformsPass. Pass already eliminates dead code and lints before handing to ARM framework for retracing. Recompiling Python GraphModule at that point is unnecessary because ExportPass call reconstructs/interprets graph rather than relying on just-compiled code object. Behavior-preserving speedup. Differential Revision: D114790128
611fdc1 to
31cb628
Compare
Summary:
Skip redundant recompile in identical-input transform fusion.
Remove redundant GraphModule.recompile() immediately before super().call() in FuseIdenticalInputTransformsPass. Pass already eliminates dead code and lints before handing to ARM framework for retracing. Recompiling Python GraphModule at that point is unnecessary because ExportPass call reconstructs/interprets graph rather than relying on just-compiled code object. Behavior-preserving speedup.
Differential Revision: D114790128