Skip to content

Skip redundant recompile in identical-input transform fusion (#22217) - #22217

Open
apullin wants to merge 1 commit into
pytorch:mainfrom
apullin:export-D114790128
Open

Skip redundant recompile in identical-input transform fusion (#22217)#22217
apullin wants to merge 1 commit into
pytorch:mainfrom
apullin:export-D114790128

Conversation

@apullin

@apullin apullin commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary:

Skip redundant recompile in identical-input transform fusion.

Remove redundant GraphModule.recompile() immediately before super().call() in FuseIdenticalInputTransformsPass. Pass already eliminates dead code and lints before handing to ARM framework for retracing. Recompiling Python GraphModule at that point is unnecessary because ExportPass call reconstructs/interprets graph rather than relying on just-compiled code object. Behavior-preserving speedup.

Differential Revision: D114790128

@apullin
apullin requested a review from digantdesai as a code owner August 27, 2026 14:51
@pytorch-bot

pytorch-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22217

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 31cb628 with merge base d58fc25 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Aug 27, 2026
@meta-codesync

meta-codesync Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@apullin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114790128.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot changed the title Skip redundant recompile in identical-input transform fusion Skip redundant recompile in identical-input transform fusion (#22217) Aug 27, 2026
apullin added a commit to apullin/executorch that referenced this pull request Aug 27, 2026
…#22217)

Summary:

Skip redundant recompile in identical-input transform fusion.

Remove redundant GraphModule.recompile() immediately before super().call() in FuseIdenticalInputTransformsPass. Pass already eliminates dead code and lints before handing to ARM framework for retracing. Recompiling Python GraphModule at that point is unnecessary because ExportPass call reconstructs/interprets graph rather than relying on just-compiled code object. Behavior-preserving speedup.

Differential Revision: D114790128
@apullin
apullin force-pushed the export-D114790128 branch from 93ed924 to 8edbba0 Compare August 27, 2026 15:16
apullin added a commit to apullin/executorch that referenced this pull request Aug 27, 2026
…#22217)

Summary:

Skip redundant recompile in identical-input transform fusion.

Remove redundant GraphModule.recompile() immediately before super().call() in FuseIdenticalInputTransformsPass. Pass already eliminates dead code and lints before handing to ARM framework for retracing. Recompiling Python GraphModule at that point is unnecessary because ExportPass call reconstructs/interprets graph rather than relying on just-compiled code object. Behavior-preserving speedup.

Differential Revision: D114790128
@apullin
apullin force-pushed the export-D114790128 branch from 8edbba0 to 611fdc1 Compare August 27, 2026 15:33
…#22217)

Summary:

Skip redundant recompile in identical-input transform fusion.

Remove redundant GraphModule.recompile() immediately before super().call() in FuseIdenticalInputTransformsPass. Pass already eliminates dead code and lints before handing to ARM framework for retracing. Recompiling Python GraphModule at that point is unnecessary because ExportPass call reconstructs/interprets graph rather than relying on just-compiled code object. Behavior-preserving speedup.

Differential Revision: D114790128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants