Correct comments on the Core ML wheel library - #22242
Open
shoumikhin wants to merge 1 commit into
Open
Conversation
Fix three comments on the standalone Core ML delegate library. Comment changes only, no behavior change. Explain that the shipped dylib is retained because it is named directly on the link line, not by anything specific to the Mach-O format, and note that only -dead_strip_dylibs would drop it, which nothing passes. Note that linking the helper archives privately also keeps their include directories out of the library's export interface, which is intended, since a wheel consumer links the bundled delegate and never names the helpers. Note that shipping the delegate as a shared library moves a duplicate-symbol conflict from static-link time to load time, and that the single shipped library and the dynamic link keep exactly one copy in the process. Test Plan: Comment-only. Confirmed both CMake files still format-parse.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22242
Note: Links to docs will display an error until the docs builds have been completed. ❌ You can merge normally! (1 Unrelated Failure), 1 Unclassified FailureAs of commit 24df64f with merge base d0c2da3 ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three comments on the standalone Core ML delegate library in the macOS wheel. Comment changes only, no behavior change.
-dead_strip_dylibswould drop it (nothing passes that).Test plan
Comment-only. Confirmed both CMake files still pass cmake-format.