Rename the profiling product to executorch_dump in the template - #22243
Open
shoumikhin wants to merge 1 commit into
Open
Rename the profiling product to executorch_dump in the template#22243shoumikhin wants to merge 1 commit into
shoumikhin wants to merge 1 commit into
Conversation
Rename the SwiftPM product from executorch_etdump to executorch_dump and its checksum placeholders to match, so it lines up with the renamed Apple Dump framework the release job publishes. The old spelling collided with the core devtools etdump library. Test Plan: Materialized the template and confirmed the product resolves under the new name and the checksum placeholders match the framework name the release job substitutes.
shoumikhin
added
the
release notes: none
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22243
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the profiling product in the SwiftPM package template from
executorch_etdumptoexecutorch_dump, matching the framework the build now produces. Without this the published package cannot resolve: the template declares a product name that no built framework provides.Renames the product key, both checksum placeholders, and the stub directories.
Test plan
Materialized the template and confirmed it parses, and that the product name matches
executorch_dumpfrom the framework build script.