Skip to content

Move _unittest.yml to linux_job_v3 #22245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huydhn wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −4
Open

Move _unittest.yml to linux_job_v3 #22245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/_docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Resolve CI docker image
# linux_job_v3 passes `docker-image` straight to the runner pod's container, which
# is pulled before any step runs, so nothing inside the job can derive it. Callers
# depend on this workflow and name the image as
# 308535385114.dkr.ecr.us-east-1.amazonaws.com/executorch/ci-image:<name>-<hash>.
# ${docker-registry}/ci-image:<name>-${ci-docker-hash}.
#
# Nothing here waits for docker-builds. A commit that changes .ci/docker needs the
# ciflow/docker label to build the images it asks for; without them the pod fails
Expand All @@ -15,6 +15,12 @@ on:
ci-docker-hash:
description: Tag suffix shared by every executorch CI image for this commit.
value: ${{ jobs.resolve.outputs.ci-docker-hash }}
docker-registry:
description: |
Registry and namespace the CI images live in. An output rather than a
literal at each call site, and not an `env`, which GitHub does not
allow in a reusable workflow's `with`.
value: 308535385114.dkr.ecr.us-east-1.amazonaws.com/executorch

permissions:
contents: read
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/_unittest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,19 @@ on:
default: 90

jobs:
docker-image:
name: Resolve CI docker image
uses: ./.github/workflows/_docker-image.yml

linux:
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
needs: docker-image
uses: pytorch/test-infra/.github/workflows/linux_job_v3.yml@main
permissions:
id-token: write
contents: read
with:
runner: linux.2xlarge.memory
docker-image: ${{ inputs.docker-image }}
runner: mt-l-x86iavx512-8-64
docker-image: ${{ needs.docker-image.outputs.docker-registry }}/${{ inputs.docker-image }}-${{ needs.docker-image.outputs.ci-docker-hash }}
submodules: 'recursive'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: ${{ inputs.linux-timeout }}
Expand Down
Loading