build(deps): bump thrift from 0.17.0 to 0.23.0 in /quickwit#6577
build(deps): bump thrift from 0.17.0 to 0.23.0 in /quickwit#6577dependabot[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab2b359cca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| serde_with = { workspace = true } | ||
| thiserror = { workspace = true } | ||
| thrift = { version = "0.17", default-features = false } | ||
| thrift = { version = "0.23", default-features = false } |
There was a problem hiding this comment.
Keep thrift aligned with parquet
When compiling quickwit-parquet-engine, this bump leaves parquet 58 locked to thrift 0.17.0 while this crate now imports thrift 0.23.0. streaming_reader.rs passes thrift::protocol::TCompactInputProtocol/TCompactOutputProtocol into PageHeader's parquet::thrift::TSerializable methods, whose protocol trait bounds come from parquet's thrift 0.17 re-export; with two thrift crate instances those are different trait/type universes, so the crate no longer type-checks. Align the direct dependency with parquet's thrift version, or update parquet at the same time.
Useful? React with 👍 / 👎.
ab2b359 to
a83441d
Compare
Bumps [thrift](https://github.com/apache/thrift) from 0.17.0 to 0.23.0. - [Release notes](https://github.com/apache/thrift/releases) - [Changelog](https://github.com/apache/thrift/blob/master/CHANGES.md) - [Commits](apache/thrift@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: thrift dependency-version: 0.23.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
a83441d to
01e809a
Compare
Bumps thrift from 0.17.0 to 0.23.0.
Release notes
Sourced from thrift's releases.
Changelog
Sourced from thrift's changelog.
... (truncated)
Commits
c4cbe43Address vulnerabilities in Rack68ac8e9Enable TLS hostname verification in TNonblockingSSLSocket5e4f01dHarden Node.js WebSocket server handlinge242889Add input validation to Swift protocol layer4af8c7cAdd recursion depth limit to Node.js protocol skip()a30c552Enable TLS hostname verification in TSSLTransportFactory276ec88THRIFT-5929: Fix build failure on PHP 8.5 due to removed zend_exception_get_d...df52ad4EXTRA_DIST fixes21a89c6build fixes630d66cadded int range checks