Skip to content

Added caching dns resolver, adding connection creation counter#6582

Closed
fulmicoton-dd wants to merge 2 commits into
mainfrom
paul.masurel/dns-caching
Closed

Added caching dns resolver, adding connection creation counter#6582
fulmicoton-dd wants to merge 2 commits into
mainfrom
paul.masurel/dns-caching

Conversation

@fulmicoton-dd

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a caching DNS resolver to the S3 HTTP client and a connection creation counter.
  • Includes the prerequisite commit that introduces the S3 HTTP client with a larger TCP buffer (required for this change to apply cleanly).

Test plan

  • cargo clippy --workspace --all-features --tests (passed locally)
  • cargo +nightly fmt --all -- --check (passed locally)
  • Manual verification of connection reuse/DNS caching behavior against S3

const S3_HTTP1_READ_BUF_SIZE: usize = 1 << 19;

static S3_TCP_CONNECTIONS_TOTAL: LazyCounter = lazy_counter!(
name: "s3_tcp_connections_total",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not an overal counter, more a creation connection counter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant