Update InterfacePlayerRDK.cpp - #247
Open
nejuma1 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The added MW_LOG_INFO(...) appears at file scope as an expression statement, which is invalid C++ and is expected to break compilation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds a log statement to InterfacePlayerRDK.cpp.
Changes:
- Inserted a
MW_LOG_INFO(...)call near the top of the file (beforeCipherToStringMap).
File summaries
| File | Description |
|---|---|
| InterfacePlayerRDK.cpp | Adds a top-level log statement in the implementation file. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| #include <assert.h> | ||
| #define GST_NORMAL_PLAY_RATE 1 | ||
|
|
||
| MW_LOG_INFO("This is to test PR"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.