Skip to content

feat: expose item index in rowKey callback - #67

Merged
zombieJ merged 1 commit into
react-component:masterfrom
aojunhao123:feat-rowkey-index
Sep 21, 2026
Merged

zombieJ merged 1 commit into
react-component:masterfrom
aojunhao123:feat-rowkey-index

Conversation

@aojunhao123

@aojunhao123 aojunhao123 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

@aojunhao123 is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9e59d41e-2892-497c-9482-d96839717062


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6b436bc) to head (1284b3c).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          222       224    +2     
  Branches        61        61           
=========================================
+ Hits           222       224    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

`rowKey` could only resolve identity from the item itself, which fails when
identity lives outside the data (e.g. a parallel key array). Align the
callback with rc-table's `(record, index) => Key`.

The index is the item position in the original `items` array, not the
rendered position - grouping reorders rows while the index stays stable.
This matches the index already passed to `itemRender`.
@zombieJ
zombieJ merged commit c806768 into react-component:master Sep 21, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants