Skip to content

perf: avoid quadratic lookup when formatting display values #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgi-gstellar wants to merge 2 commits into
base: master
Choose a base branch
from
+35 −1
Open

perf: avoid quadratic lookup when formatting display values #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d8e13
perf: optimize display value label lookup
georgi-gstellar Sep 22, 2026
7e770c5
test: update test to cover duplicate values
georgi-gstellar Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/TreeSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,18 @@ const TreeSelect = React.forwardRef<BaseSelectRef, TreeSelectProps>((props, ref)
// Convert to value and filled with label
const values = displayKeys.map(key => keyEntities[key]?.node?.[mergedFieldNames.value] ?? key);

// Avoid an O(displayed values × selected values) lookup
const labeledValueMap = new Map<SafeKey, LabeledValueType>();
rawLabeledValues.forEach(item => {
// Match `find` by keeping the first entry when controlled values contain duplicates.
if (!labeledValueMap.has(item.value)) {
labeledValueMap.set(item.value, item);
}
});

// Back fill with origin label
const labeledValues = values.map(val => {
const targetItem = rawLabeledValues.find(item => item.value === val);
const targetItem = labeledValueMap.get(val);
const label = labelInValue ? targetItem?.label : treeTitleRender?.(targetItem);
return {
value: val,
Expand Down
25 changes: 25 additions & 0 deletions tests/Select.checkable.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,31 @@ describe('TreeSelect.checkable', () => {
expect(getSelectionText(container, 0)).toEqual('0-0');
});

it('preserves labels with SHOW_ALL', () => {
const { container } = render(
<TreeSelect
treeCheckable
showCheckedStrategy={SHOW_ALL}
labelInValue
value={[
{ value: 'parent', label: 'First parent label' },
{ value: 'parent', label: 'Second parent label' },
{ value: 'child', label: 'Custom child' },
]}
>
<TreeNode key="parent" value="parent" title="Parent">
<TreeNode key="child" value="child" title="Child" />
</TreeNode>
</TreeSelect>,
);

expect(getSelections(container)).toHaveLength(2);
expect([getSelectionText(container, 0), getSelectionText(container, 1)]).toEqual([
'First parent label',
'Custom child',
]);
});

// https://github.com/ant-design/ant-design/issues/38126
it('keep label when not in options', () => {
const onChange = jest.fn();
Expand Down