docs, comments: fix typos - #1755
Open
durvesh1992 wants to merge 2 commits into
Open
Conversation
- docs/Resolution.md: fix broken anchor #resolvereqeuest -> #resolverequest (the linked heading in Configuration.md is "resolveRequest"), and "A alternative" -> "An alternative". - Fix comment/test-description typos: occured -> occurred, begining -> beginning, succesfully -> successfully, wont' -> won't, indiciate -> indicate, enviornment -> environment. - exclusionList-test.js: rename local helper setPathSeperator -> setPathSeparator (Seperator -> Separator), matching the existing originalSeparator variable. All comment/doc/test-name only; no runtime behavior changes.
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Summary:
The website build reports ten broken anchors and ships anyway. Fix them, and set `onBrokenAnchors: 'throw'` so the next one fails the build instead of accumulating.
Most are stale or mistyped anchors:
| link | fixed to |
|---|---|
| `#require-resolveweak` | `#requireresolveweak` |
| `#extranodemodules` | `#extranodemodules-string-string` |
| `#disableHierarchicalLookup-boolean` | `#disablehierarchicallookup-boolean` |
| `#resolve_package-exports` | `#resolve_package_exports` |
| `#doesfileexist-string--boolean` | `#doesfileexist-string--boolean-deprecated` |
| `#dev` | `#dev-boolean` |
| `configuration#resolvereqeuest` | `configuration#resolverequest` |
Two were not just anchors:
- `context.enablePackageExports` has been `unstable_enablePackageExports` since it was introduced, and the link pointed at a heading that never existed on that page. Corrected the name in both prose and link, and pointed it at the config entry, matching how RESOLVE_PACKAGE_EXPORTS already refers to it.
- `resolver.assetResolutions` is a real option (`metro-config/src/types.js`) with three inbound doc links but no entry in Configuration.md. Documented it, with the default and the `@${resolution}x` filename form the default `resolveAsset` uses.
Note this includes the `resolvereqeuest` fix also made by #1755, which additionally fixes some code comment typos.
Pull Request resolved: #1922
Test Plan:
`yarn build` in `website/` passes with no broken anchors reported.
Confirmed `onBrokenAnchors: 'throw'` actually takes effect: adding a deliberate `#this-anchor-does-not-exist` link fails the build with `Docusaurus found broken anchors!`, and removing it passes again.
Reviewed By: cipolleschi
Differential Revision: D119472681
Pulled By: vzaidman
fbshipit-source-id: 439cd076205166f45d35dc3a65ee535416e30a19
robhogan
changed the title
robhogan
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small documentation/comment fixes: one broken doc anchor plus a batch of typo corrections in comments and test names. No runtime behavior changes.
Broken doc linkdocs/Resolution.mdlinked to./Configuration.md#resolvereqeuest, but the heading inConfiguration.mdisresolveRequest, so the anchor resolves to#resolverequest. The old link was dead.Edit (rob): Fixed in #1922
Changes
docs/Resolution.md#resolvereqeuest(dead anchor)#resolverequestdocs/Resolution.mdpackages/metro-resolver/src/PackageResolve.jspackages/metro-runtime/.../MetroFastRefreshMockRuntime.jspackages/metro-file-map/src/watchers/NativeWatcher.jspackages/metro-file-map/src/watchers/NativeWatcher.jspackages/buck-worker-tool/.../worker-test.jspackages/metro-config/.../exclusionList-test.jspackages/metro-config/.../exclusionList-test.jssetPathSeperator(local helper)setPathSeparator(matches existingoriginalSeparator)Test plan
Comment/doc/test-name only.
setPathSeperatoris a function local toexclusionList-test.js; all 5 references were renamed together. No production code paths affected.