Fix RAM bundle passing the deps function (not its result) to getTransformOptions - #1757
Open
durvesh1992 wants to merge 5 commits into
Open
Fix RAM bundle passing the deps function (not its result) to getTransformOptions#1757durvesh1992 wants to merge 5 commits into
durvesh1992 wants to merge 5 commits into
Conversation
…formOptions getRamBundleInfo gives custom getTransformOptions a callback to look up a module's transitive dependencies, but it called `Array.from(getDependencies)` on the function itself instead of `Array.from(getDependencies(x))`. Since the closure has arity 1, Array.from treated it as array-like and returned [undefined], so any getTransformOptions relying on this callback received garbage regardless of the file queried. Invoke getDependencies(x). Existing tests never exercised the callback, which masked this. Adds a regression test that calls the callback and asserts the real transitive deps (fails before / passes after).
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
`resolvedDeps` was declared without a type or initialiser, so spreading it fails `flow check` with "possibly uninitialized variable is incompatible with $Iterable". Annotate it and assert it was assigned before spreading, which also gives a clearer failure if `getTransformOptions` is never called with a dependency lookup. Changelog: [Internal]
…back The suppression dates to Flow v0.99 in 2019 and no longer suppresses anything: `flow check` reports no error on this line with it removed, either with the fix in this stack or with the original `Array.from(getDependencies)`. Worth noting Flow did not catch this bug in either form, for the same reason it was silent at runtime - `Array.from` accepts array-likes, and a function satisfies that via `.length`. Changelog: [Internal]
The guard added in the previous commit exceeded the print width, failing `prettier --check` and so `yarn lint`. Changelog: [Internal]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getRamBundleInfohands customgetTransformOptionsa callback to look up a module's transitive dependencies. But it builds that callback as:getDependenciesis the function(filePath) => getTransitiveDependencies(filePath, graph). This callsArray.fromon the function itself and ignoresx— it never invokesgetDependencies. Since the closure has arity 1,Array.fromtreats it as array-like via.lengthand returns[undefined]. So anygetTransformOptionsthat uses this callback to computepreloadedModules/ramGroupsreceives[undefined]for every file it asks about.Fix
Changelog: [Fix] RAM bundle builds now pass real transitive dependencies to a custom
getTransformOptionsTest plan
Added a regression test that supplies a
getTransformOptionswhich calls the callback for/root/foo.jsand asserts it returns foo's transitive deps (bar,baz,qux). Fails before ([undefined]), passes after. Existing tests + snapshots unchanged (4 passed, 2 snapshots).