Skip to content

Make react/renderer/components/image public (#58437) - #58437

Closed
j-piasecki wants to merge 1 commit into
react:mainfrom
j-piasecki:export-D119477736
Closed

Make react/renderer/components/image public (#58437)#58437
j-piasecki wants to merge 1 commit into
react:mainfrom
j-piasecki:export-D119477736

Conversation

@j-piasecki

@j-piasecki j-piasecki commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary:

Classifies react/renderer/components/image:image as a public target under the C++ stable API three-tier visibility model. Replaces the FrameworksGuard.h include in the module's 6 exported headers with <react/cxxstableapi/UmbrellaGuard.h> and introduces the module umbrella React/Image.h, wiring the umbrella into BUCK, CMake, CocoaPods, the iOS prebuild header config and the Android prefab export.

Changelog:
[General][Added] - Added umbrella header for the react/renderer/components/image module

Differential Revision: D119477736

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 10, 2026
@meta-codesync

meta-codesync Bot commented Sep 10, 2026

Copy link
Copy Markdown

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119477736.

Summary:

Classifies `react/renderer/components/image:image` as a public target under the C++ stable API three-tier visibility model. Replaces the `FrameworksGuard.h` include in the module's 6 exported headers with `<react/cxxstableapi/UmbrellaGuard.h>` and introduces the module umbrella `React/Image.h`, wiring the umbrella into BUCK, CMake, CocoaPods, the iOS prebuild header config and the Android prefab export.

Changelog:
[General][Added] - Added umbrella header for the `react/renderer/components/image` module

Differential Revision: D119477736
@meta-codesync meta-codesync Bot changed the title Make react/renderer/components/image public Make react/renderer/components/image public (#58437) Sep 10, 2026
j-piasecki added a commit to j-piasecki/react-native that referenced this pull request Sep 10, 2026
Summary:

Classifies `react/renderer/components/image:image` as a public target under the C++ stable API three-tier visibility model. Replaces the `FrameworksGuard.h` include in the module's 6 exported headers with `<react/cxxstableapi/UmbrellaGuard.h>` and introduces the module umbrella `React/Image.h`, wiring the umbrella into BUCK, CMake, CocoaPods, the iOS prebuild header config and the Android prefab export.

Changelog:
[General][Added] - Added umbrella header for the `react/renderer/components/image` module

Differential Revision: D119477736
@meta-codesync meta-codesync Bot closed this in a9203b8 Sep 11, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Sep 11, 2026
@meta-codesync

meta-codesync Bot commented Sep 11, 2026

Copy link
Copy Markdown

This pull request has been merged in a9203b8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant