Remove globals defined for the React renderer that are now unused (#58454) - #58454
Open
rubennorte wants to merge 6 commits into
Open
Remove globals defined for the React renderer that are now unused (#58454)#58454rubennorte wants to merge 6 commits into
rubennorte wants to merge 6 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119498576. |
meta-codesync
Bot
changed the title
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 13:58
cf4c858 to
a99a1cc
Compare
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 14:05
a99a1cc to
1cc42c7
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Differential Revision: D119498576
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 14:12
1cc42c7 to
651d72b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 14:21
651d72b to
2add998
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 14:31
2add998 to
13e2163
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 14:37
13e2163 to
5b8f62e
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 15:12
5b8f62e to
b1888f0
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 15:21
b1888f0 to
5d4af30
Compare
Differential Revision: D119490598
Summary: Remove the isOSS conditionals that were skipping Fantom renderer tests in OSS environments. Now that the React Native renderers have been upgraded and the code is compatible in OSS, these tests can run in both internal and OSS environments. Changes: - ResponderEventTarget-itest.js: Removed isOSS check that skipped the entire Responder System test suite - EventTargetDispatching-itest.js: Removed isOSS check that skipped the entire EventTarget-based Event Dispatching test suite - EventDispatching-benchmark-itest.js: Removed if (isOSS) block that provided a dummy test instead of the benchmark suite - EventDispatching-itest.js: Removed if (!isOSS) condition guarding three tests for native event timeStamp and global event dispatching Changelog: [Internal] Differential Revision: D107675643
Summary: The renderer can dispatch events either through the legacy plugin-based system or through the W3C EventTarget API (addEventListener/dispatchEvent), gated behind the enableNativeEventTargetEventDispatching feature flag. Enabling it by default was previously blocked on the renderer, which did not carry the necessary changes until React 19.3.0. That sync has now landed, so flip the flag's default value to true and drop the TODO that tracked the blocker. Fully removing the flag and the legacy dispatch path is left for a follow-up. Changelog: [General][Changed] - Dispatch events through the EventTarget API by default Differential Revision: D119495069
Differential Revision: D119166138
Summary: The `react-private-interface` and `setup-env` entry points now provide the private contract between React and React Native that `Libraries/ReactPrivate/` forwarded to, so the deprecated forwarding modules can be removed. **This diff** - Delete `Libraries/ReactPrivate/` — `ReactNativePrivateInterface`, `ReactNativePrivateInitializeCore`, and their `.flow`/`README` files. - Repoint internal `packages/react-native` imports directly at their source modules instead of the `react-private-interface` aggregator: `AnimatedProps` and two integration tests now import `getNodeFromPublicInstance` from `ReactFabricPublicInstance`, and `index.js.flow` re-exports `PublicRootInstance`/`PublicTextInstance` from there (adding a `PublicTextInstance` export to that module). - Repoint the remaining consumers at the `react-native/react-private-interface` entry point. - Drop the stale `Libraries/ReactPrivate/ReactNativePrivateInterface` entries from the eslint and Flow-codemod `publicAPIMapping`s and the `rn-arch` migration-list filters. Changelog: [Internal] Differential Revision: D114055938
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 10, 2026
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 15:45
5d4af30 to
420588f
Compare
…act#58454) Summary: Pull Request resolved: react#58454 The OSS renderer has been upgraded and it's no longer consuming these globals. Changelog: [internal] Reviewed By: christophpurrer Differential Revision: D119498576
rubennorte
force-pushed
the
export-D119498576
branch
from
September 10, 2026 15:52
420588f to
9652966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The OSS renderer has been upgraded and it's no longer consuming these globals.
Changelog: [internal]
Reviewed By: christophpurrer
Differential Revision: D119498576