Skip to content

fix: scrollRectToVisible on frame size change in RCTTextInputComponentView - #58520

Open
abulenok wants to merge 1 commit into
react:mainfrom
abulenok:ob/fix-no-scroll-on-newline
Open

abulenok wants to merge 1 commit into
react:mainfrom
abulenok:ob/fix-no-scroll-on-newline

Conversation

@abulenok

@abulenok abulenok commented Sep 14, 2026

Copy link
Copy Markdown

Summary:

Fixes #58517

UIKit checks caret visibility inside the text change, but RCTTextInputComponentView
grows RCTUITextView one mount later (the new size comes from Yoga). The new line has no layout yet, so the check reveals the old line, and UIKit never checks again.

Fix: when updateLayoutMetrics applies a taller frame to a focused input do scrollRectToVisible - growth and scroll land in the same mount

Changelog:

[IOS] [FIXED] - Fixed multiline TextInput inside a ScrollView not being scrolled when a new line is entered on the New Architecture

Test Plan:

Tested the fix with the repro app from the issue:

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-09-15.at.13.15.31.mov

Before:

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-09-15.at.12.50.38.mov

@meta-cla

meta-cla Bot commented Sep 14, 2026

Copy link
Copy Markdown

Hi @abulenok!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@abulenok abulenok changed the title fix: scrollRectToVisible on frame size change in RCTTextInputComponentView fix: scrollRectToVisible on frame size change in RCTTextInputComponentView Sep 14, 2026
@meta-cla

meta-cla Bot commented Sep 14, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2026
@abulenok
abulenok marked this pull request as ready for review September 15, 2026 12:16
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScrollView doesn't scroll up on new line in TextInput

1 participant