Conversation
|
Hi @abulenok! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
scrollRectToVisible on frame size change in RCTTextInputComponentView
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Fixes #58517
UIKit checks caret visibility inside the text change, but RCTTextInputComponentView
grows RCTUITextView one mount later (the new size comes from Yoga). The new line has no layout yet, so the check reveals the old line, and UIKit never checks again.
Fix: when updateLayoutMetrics applies a taller frame to a focused input do
scrollRectToVisible- growth and scroll land in the same mountChangelog:
[IOS] [FIXED] - Fixed multiline TextInput inside a ScrollView not being scrolled when a new line is entered on the New Architecture
Test Plan:
Tested the fix with the repro app from the issue:
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-09-15.at.13.15.31.mov
Before:
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-09-15.at.12.50.38.mov