Fixed #1131 - Race condition between SuspendNotifications() and .ResumeNotifications()#1132
Open
JakenVeina wants to merge 1 commit into
Open
Fixed #1131 - Race condition between SuspendNotifications() and .ResumeNotifications()#1132JakenVeina wants to merge 1 commit into
SuspendNotifications() and .ResumeNotifications()#1132JakenVeina wants to merge 1 commit into
Conversation
…synchronize updates to internal state for tracking notification suspensions, but `.ResumeNotifications()` did not use any synchronization when updating that same state, allowing for corruption of state if the two methods happen to overlap, concurrently. Also fixed that the test for this behavior was intermittent, specifically that it tended to falsely pass when running in parallel with many other tests. The test has now been moved to its own `IntegrationTests` fixture, to guarantee it is never parallelized with other tests. Resolves #1131.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed that
ObservableCache.SuspendNotifications()uses alockto synchronize updates to internal state for tracking notification suspensions, but.ResumeNotifications()did not use any synchronization when updating that same state, allowing for corruption of state if the two methods happen to overlap, concurrently.Also fixed that the test for this behavior was intermittent, specifically that it tended to falsely pass when running in parallel with many other tests. The test has now been moved to its own
IntegrationTestsfixture, to guarantee it is never parallelized with other tests.Resolves #1131.
@dwcullop I suspect this may not be a proper fix, in the context of
DeliveryQueue<>. I.E. this solution involves using a basiclock()when perhaps the proper solution should be using the locking mechanisms uponDeliveryQueue<>. But I don't have the familiarity with it. For now, I just duplicated the existinglock(_locker)upon.SuspendNotifications()over to.ResumeNotifications(). If you'd rather take a crack at this yourself instead, go for it.The test changes we should definitely keep, though.