[PostRector] Skip inline {@see } used use statement on remove unused imports

[samsonasik]

Fixes rectorphp/rector#9781

[samsonasik]

Fixed 🎉 /cc @mspirkov

[mspirkov]

Thanks!

[samsonasik]

@TomasVotruba ready 👍

[cosmastech]

Does this account for @throws as well?

[samsonasik]

Only for inline {@see ...}, {@uses ... }, {@used-by ... }

[cosmastech]

Only for inline {@see ...}, {@uses ... }, {@used-by ... }

Should @throws be added as well? That's also broken.

[samsonasik]

Could you give example reference?

[samsonasik]

I can't found anywhere use of inline {@throws ...} with curly {} braces, if you can give me documentation of that usage, I may can add to the patch.

[samsonasik]

@TomasVotruba ready 👍

[cosmastech]

I can't found anywhere use of inline {@throws ...} with curly {} braces, if you can give me documentation of that usage, I may can add to the patch.

Sorry, I misunderstood that this was specifically for curly braces. Perhaps it's a separate PR that needs created.

I upgraded and ran rector yesterday. I had a class like this:

namespace MyApp\Interfaces;

use MyApp\Exceptions\NotFoundException;

interface MyService
{
    /**
     * @throws NotFoundException
     */
    public function add(int $id): void;
}

Running rector, the use MyApp\Exceptions\NotFoundException; was stripped off.

edit: Just tried reproducing this and couldn't. 🤔 Sorry for the confusion!

[samsonasik]

That should already covered by previous PR that skip feature should clear php doc attribute early:

• [AutoImport] Avoid used import into param that skipped from removal rule #8078

Try latest dev-main, if the issue persist, fill free to provide failing fixture on separate PR.

Thank you.

[cosmastech]

That should already covered by previous PR that skip feature should clear php doc attribute early:

• [AutoImport] Avoid used import into param that skipped from removal rule #8078

Try latest dev-main, if the issue persist, fill free to provide failing fixture on separate PR.

Thank you.

It turns out someone had written /* @throws SomeException */ 🫠

Sorry for all the confusion!

[samsonasik]

@TomasVotruba ready 👍

[TomasVotruba]

Thanks 🙏