[CodeQuality] Add NegatedAndsToPositiveOrsRector#8082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspiration from: mautic/mautic@657e1df#r3468116767
What
Adds a new rule
NegatedAndsToPositiveOrsRectorthat applies De Morgan to a negated AND:!(A && B)→!A || !B.This is the missing counterpart to the existing
SimplifyDeMorganBinaryRector, which only handles a negated OR (!(A || B)→!A && !B). The two directions are kept as separate, focused rules.Examples
Real-world case (
empty()+in_array()):Comparison operators:
What changed
rules/CodeQuality/Rector/BooleanNot/NegatedAndsToPositiveOrsRector.php— subscribes toBooleanNot, transforms a wrappedBooleanAndinto aBooleanOrof the inverted operands.BinaryOpManipulator::inverseBooleanAnd()— new helper mirroringinverseBooleanOr(); inverts each operand and joins with||. Skips nested&&to avoid partial rewrites. The sharedresolveInversedNodeClass()is intentionally untouched, sinceinvertCondition()relies on it keeping operands in place.CodeQualityLevel::RULES.rules-tests/CodeQuality/Rector/BooleanNot/NegatedAndsToPositiveOrsRector/— covers the empty/in_array case, comparison operators, and skip cases (negated OR, nested AND).SimplifyDeMorganBinaryRectoris left unchanged.