Skip to content

[DeadCode] Fix offset access + drop phpstan ignore in RemoveParentDelegatingConstructorRector #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomasVotruba wants to merge 1 commit into from
+4 −7
Closed

[DeadCode] Fix offset access + drop phpstan ignore in RemoveParentDelegatingConstructorRector #8369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,6 @@ parameters:
identifier: offsetAccess.nonArray
path: src/PhpParser/NodeTraverser/RectorNodeTraverser.php

# known non-empty class method
-
identifier: offsetAccess.notFound
message: '#Offset 0 might not exist on array<PhpParser\\Node\\Stmt>\|null#'
path: rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector.php

-
identifier: offsetAccess.notFound
message: '#Offset float\|int\|string might not exist on string#'
Expand Down
5 changes: 4 additions & 1 deletion rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,10 @@ private function matchParentConstructorCallArgs(Stmt $stmt): ?array

private function isParameterAndArgCountAndOrderIdentical(ClassMethod $classMethod): bool
{
$soleStmt = $classMethod->stmts[0];
$soleStmt = $classMethod->stmts[0] ?? null;
if (! $soleStmt instanceof Stmt) {
return false;
}

$parentCallArgs = $this->matchParentConstructorCallArgs($soleStmt);
if ($parentCallArgs === null) {
Expand Down
Loading