feat(lightspeed): replace RAG init container with OKP deployment - #500
feat(lightspeed): replace RAG init container with OKP deployment#500maysunfaisal wants to merge 2 commits into
Conversation
8780222 to
73fafce
Compare
|
Corresponding rhdh-operator PR redhat-developer/rhdh-operator#3370 |
There was a problem hiding this comment.
@maysunfaisal Note that the charts/backstage is being deprecated on main in favor of a brand-new standalone charts/rhdh chart - see #438
I'm just back from vacation but I'm hoping we can get #438 merged as soon as possible. So it'll be great if your changes here could be applied against this new rhdh chart instead. Thanks for your understanding.
|
/hold |
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
@maysunfaisal FYI, #438 has just been merged. So it'll be great if your changes here could be applied against this new rhdh chart instead. Thanks.
@rm3l Thanks Armel, let me take a look on Tuesday |
73fafce to
25dde1b
Compare
25dde1b to
f66eed3
Compare
…DP-16102] Replace the RAG init container / FAISS vector store with an OKP (Offline Knowledge Portal) Deployment, Service, and Route. Add platform-aware config selection: OpenShift (or K8s with okp.ingress.host set) uses the full OKP config; vanilla K8s uses the lightspeed-stack-no-okp.yaml variant so LCORE does not crash without an OKP backend. Add OKP Ingress support, imagePullSecrets, vector_store config, and align/pin the OKP and LCORE (OGX) images. Swap Lightspeed plugins to Intelligent Assistant. Add systemArgs/systemEnv for LCORE sidecar (HF_HOME, OTEL_SDK_DISABLED, --synthesized-config-output). Sync vendored Lightspeed configs from lightspeed-configs@main. Add docs/lightspeed.md with deployment scenarios, vanilla K8s prerequisites, and OKP configuration reference. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
f66eed3 to
03f9ea9
Compare
Jdubrick
left a comment
Jdubrick
left a comment
There was a problem hiding this comment.
Generally looks good. I think there is some stale RAG references in the readmes though
| - name: OTEL_SDK_DISABLED | ||
| value: "true" |
There was a problem hiding this comment.
If we set it here should it also be included in secret.example.yaml, or wdyt?
There was a problem hiding this comment.
Thats true, we can remove it from secret.example.yaml
| {{- $lightspeed := include "rhdh.lightspeed" . | fromYaml -}} | ||
| {{- if include "rhdh.lightspeed.okp.active" . }} | ||
| apiVersion: apps/v1 | ||
| kind: Deployment |
There was a problem hiding this comment.
I think everything else runs as non-root in this chart, does this need to follow suit or is it special?
There was a problem hiding this comment.
Addressed in the latest commit, added allowPrivilegeEscalation: false, runAsNonRoot: true, capabilities.drop: [ALL], and seccompProfile: RuntimeDefault to match the other containers. readOnlyRootFilesystem: true isn't feasible here since Solr (via Lucene) needs to write a lock file into its pre-built index directory at runtime, which is baked into the image.
…[RHIDP-16102] - Add securityContext to OKP deployment (allowPrivilegeEscalation: false, runAsNonRoot: true, capabilities.drop: [ALL], seccompProfile: RuntimeDefault) - Fix CI test failure: use lightspeed-stack-no-okp.yaml for upgrade test ConfigMap to avoid LCORE crash against missing OKP services - Remove OTEL_SDK_DISABLED from secret.example.yaml (managed by chart) - Remove stale RAG init container references from README and values.yaml Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
@rm3l @gazarenkov can i also get a review on this PR alongside redhat-developer/rhdh-operator#3370 (same idea) |
3 participants
Description of the change
Replace the Lightspeed RAG init container / FAISS vector store with an OKP (Offline Knowledge Portal) backend and swap the Lightspeed dynamic plugins to the Intelligent Assistant plugins.
OKP deployment
Deployment,Service,Route, andIngresstemplates (Solr8983+ httpd8080) undertemplates/lightspeed/._helpers.tpl): OpenShift — or K8s withokp.ingress.hostset — uses the full OKP config; vanilla K8s useslightspeed-stack-no-okp.yamlso LCORE does not crash without an OKP backend.okp.*values (image, replicas, Solr memory, ingress, imagePullSecrets); OKP image pinned toregistry.redhat.io/offline-knowledge-portal/rhokp-rhel9:1.2.10-1786628394.Plugin swap (Intelligent Assistant)
values.yamlFE + BE plugins →oci://quay.io/rhdh/red-hat-developer-hub-backstage-plugin-intelligent-assistant(-backend):{{ "{{inherit}}" }},enabled: true.Config & images
lightspeed-stack.yaml(OKP) +lightspeed-stack-no-okp.yaml(no-OKP), addvector_storeconfig, updaterhdh-profile.py/secret.yaml.quay.io/lightspeed-core/lightspeed-stack:dev-20260811-0da4b12); drop the RAG init container frombackstage-deployment.yaml.lightspeed-configs@main(hack/sync-lightspeed-configs.sh).Which issue(s) does this PR fix or relate to
https://redhat.atlassian.net/browse/RHIDP-16102
How to test changes / Special notes to the reviewer
On OpenShift:
lightspeedenabled and provide your inference key (e.g.OPENAI_API_KEY) via the Lightspeed secret.lightspeed-coresidecar (no RAG init container); OKPDeployment/Service/Route1/1 Running.OKP_SERVICE_URLinjected into the sidecar; LCOREGET /v1/modelsreturns 200.On vanilla K8s:
okp.ingress.host: OKP is skipped,lightspeed-stack-no-okp.yamlis used, LCORE starts without crashing.okp.ingress.hostset: OKP + Ingress are deployed and used.Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md (regenerated via thehelm-docspre-commit hook).pre-commithook.ct lintcommand.orchestrator-infrachart not touched.