Skip to content

chore(app-defaults): add fixed changeset group for app-defaults and app-react - #4443

Open
christoph-jerolimov wants to merge 1 commit into
mainfrom
chore/app-defaults-changeset-fixed-group
Open

chore(app-defaults): add fixed changeset group for app-defaults and app-react#4443
christoph-jerolimov wants to merge 1 commit into
mainfrom
chore/app-defaults-changeset-fixed-group

Conversation

@christoph-jerolimov

Copy link
Copy Markdown
Member

Summary

  • Adds a fixed group to the changeset config so that @red-hat-developer-hub/backstage-plugin-app-defaults and @red-hat-developer-hub/backstage-plugin-app-react are always released together with the same version number.

Test plan

  • Verify the changeset config is valid JSON
  • Confirm that future changeset version bumps apply to both packages simultaneously

🤖 Generated with Claude Code

…pp-react

Ensures both packages are always released together with the same version
number by adding a fixed group to the changeset config.

Signed-off-by: Christoph Jerolimov <christoph@2-45.de>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Changesets: fix app-defaults and app-react to release in lockstep

⚙️ Configuration changes ✨ Enhancement 🕐 Less than 10 minutes

Grey Divider

AI Description

• Configure Changesets to treat app-defaults and app-react as a fixed version group.
• Ensure both packages are always released together with the same version number.
• Prevent accidental version drift between the two closely-coupled app packages.
Diagram

graph TD
  A["Release workflow"] --> B["workspaces/app-defaults/.changeset/config.json"] --> C["@changesets/cli"] --> D["Fixed group: app-defaults + app-react"] --> E[("Package registry")]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Use a Changesets `linked` group instead of `fixed`
  • ➕ Less strict coupling (only links bump behavior rather than forcing permanent lockstep in all cases)
  • ➕ May be preferable if occasional independent releases are desired
  • ➖ Higher chance of version drift if the coupling expectation is truly “always the same version”
  • ➖ Does not communicate as strongly that the packages are effectively a single release unit
2. Consolidate into a single package (or a shared internal package)
  • ➕ Eliminates multi-package coordination and lockstep versioning needs
  • ➕ Reduces publication surface area
  • ➖ Larger refactor with broader dependency and import-path churn
  • ➖ Not suitable if packages have distinct consumers or distribution requirements

Recommendation: Keeping the two packages in a Changesets fixed group is the best fit when they must always ship together and share a version. It is the smallest change with the clearest enforcement of the intended release contract; linked was a plausible alternative but is weaker if strict lockstep is required.

Files changed (1) +6 / -0

Other (1) +6 / -0
config.jsonAdd fixed-group release lockstep for app-defaults and app-react +6/-0

Add fixed-group release lockstep for app-defaults and app-react

• Adds a Changesets 'fixed' group containing the app-defaults and app-react packages. This forces both packages to be released together using the same version number to prevent drift.

workspaces/app-defaults/.changeset/config.json

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.62%. Comparing base (277f374) to head (3a7e4c6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4443   +/-   ##
=======================================
  Coverage   61.62%   61.62%           
=======================================
  Files        2541     2541           
  Lines      101893   101893           
  Branches    28530    28530           
=======================================
  Hits        62792    62792           
  Misses      37297    37297           
  Partials     1804     1804           
Flag Coverage Δ *Carryforward flag
adoption-insights 84.55% <ø> (ø) Carriedforward from 277f374
ai-integrations 67.70% <ø> (ø) Carriedforward from 277f374
app-defaults 48.37% <ø> (ø)
augment 46.67% <ø> (ø) Carriedforward from 277f374
boost 79.84% <ø> (ø) Carriedforward from 277f374
bulk-import 72.79% <ø> (ø) Carriedforward from 277f374
cost-management 13.55% <ø> (ø) Carriedforward from 277f374
dcm 72.09% <ø> (ø) Carriedforward from 277f374
e2e-adoption-insights 60.00% <ø> (ø) Carriedforward from 277f374
e2e-extensions 62.13% <ø> (ø) Carriedforward from 277f374
e2e-global-header 49.45% <ø> (ø) Carriedforward from 277f374
e2e-homepage 61.11% <ø> (ø) Carriedforward from 277f374
e2e-intelligent-assistant 46.68% <ø> (ø) Carriedforward from 277f374
e2e-orchestrator 49.51% <ø> (ø) Carriedforward from 277f374
e2e-quickstart 55.21% <ø> (ø) Carriedforward from 277f374
e2e-scorecard 50.21% <ø> (ø) Carriedforward from 277f374
e2e-theme 16.36% <ø> (ø) Carriedforward from 277f374
extensions 56.59% <ø> (ø) Carriedforward from 277f374
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 277f374
global-header 66.50% <ø> (ø) Carriedforward from 277f374
homepage 47.46% <ø> (ø) Carriedforward from 277f374
install-dynamic-plugins 58.57% <ø> (ø) Carriedforward from 277f374
intelligent-assistant 75.35% <ø> (ø) Carriedforward from 277f374
konflux 91.98% <ø> (ø) Carriedforward from 277f374
lightspeed 69.02% <ø> (ø) Carriedforward from 277f374
mcp-integrations 83.40% <ø> (ø) Carriedforward from 277f374
orchestrator 70.92% <ø> (ø) Carriedforward from 277f374
quickstart 63.74% <ø> (ø) Carriedforward from 277f374
sandbox 79.56% <ø> (ø) Carriedforward from 277f374
scorecard 87.40% <ø> (ø) Carriedforward from 277f374
theme 88.91% <ø> (ø) Carriedforward from 277f374
translations 5.12% <ø> (ø) Carriedforward from 277f374
x2a 79.20% <ø> (ø) Carriedforward from 277f374

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277f374...3a7e4c6. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can switch off images and animations for a plain-text comment

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added the enhancement New feature or request label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant