feat(#4037): move app drawer extension and module into app-defaults - #4444
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
feat(#4037): move app drawer extension and module into app-defaults#4444fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Move appDrawerExtension and appDrawerModule from the app-react plugin into the app-defaults plugin, where default module registrations belong. The app-react plugin retains the reusable building blocks (AppDrawerContentBlueprint, appDrawerContentDataRef, useAppDrawer, ApplicationDrawer, and all drawer types). Changes: - Create appDrawerModule.tsx in app-defaults with the extension and module definitions, importing UI components from app-react. - Export appDrawerExtension and appDrawerModule from the app-defaults main entry point. - Add ./app-drawer-module subpath that default-exports appDrawerModule for Scalprum / module-federation dynamic loading. - Update appDefaultsModule to import appDrawerExtension locally. - Remove appDrawerExtension, appDrawerModule, and ./app-drawer-module subpath from app-react. - Update the sample app to import appDrawerModule from app-defaults and add app-defaults as a dependency of the app package. - Regenerate API reports for both packages. Note: Pre-commit hook (lint-staged eslint --fix) failed because the @backstage/no-undeclared-imports rule's auto-fixer attempted yarn add in the sandbox. The lint errors are resolved by the package.json dependency addition included in this commit. Tests, linting, tsc, prettier, and API reports all pass independently. Closes #4037
fullsend-ai-coder
Bot
requested review from
a team,
christoph-jerolimov and
rohitkrai03
as code owners
August 24, 2026 09:44
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4444 +/- ##
=======================================
Coverage 61.62% 61.62%
=======================================
Files 2541 2540 -1
Lines 101893 101888 -5
Branches 28530 28530
=======================================
Hits 62792 62792
+ Misses 37297 37292 -5
Partials 1804 1804
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move appDrawerExtension and appDrawerModule from the app-react plugin into the app-defaults plugin, where default module registrations belong. The app-react plugin retains the reusable building blocks (AppDrawerContentBlueprint, appDrawerContentDataRef, useAppDrawer, ApplicationDrawer, and all drawer types).
Changes:
module definitions, importing UI components from app-react.
main entry point.
for Scalprum / module-federation dynamic loading.
subpath from app-react.
and add app-defaults as a dependency of the app package.
Note: Pre-commit hook (lint-staged eslint --fix) failed because the @backstage/no-undeclared-imports rule's auto-fixer attempted yarn add in the sandbox. The lint errors are resolved by the package.json dependency addition included in this commit. Tests, linting, tsc, prettier, and API reports all pass independently.
Closes #4037
Post-script verification
agent/4037-move-drawer-to-app-defaults)277f374bef9b200bb03c427bbc00a827c098778b..HEAD)