fix(global-header): fixes the global header company logo ignoring app.branding.fullLogo - #4466
Open
debsmita1 wants to merge 2 commits into
Open
fix(global-header): fixes the global header company logo ignoring app.branding.fullLogo#4466debsmita1 wants to merge 2 commits into
debsmita1 wants to merge 2 commits into
Conversation
debsmita1
requested review from
a team,
ciiay and
divyanshiGupta
as code owners
August 25, 2026 14:02
Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4466 +/- ##
=======================================
Coverage 61.59% 61.60%
=======================================
Files 2565 2568 +3
Lines 102734 102679 -55
Branches 28753 28725 -28
=======================================
- Hits 63279 63253 -26
+ Misses 37639 37621 -18
+ Partials 1816 1805 -11
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
debsmita1
force-pushed
the
global-header-logo
branch
from
August 25, 2026 19:20
c99e6d8 to
0b3afe6
Compare
debsmita1
force-pushed
the
global-header-logo
branch
from
August 25, 2026 19:21
0b3afe6 to
ce7964d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Resolves:
https://redhat.atlassian.net/browse/RHDHBUGS-3670
Solution description:
Fixes the global header company logo ignoring app.branding.fullLogo by removing hardcoded RHDH logo overrides from the default NFS extension and legacy OFS mount points. CompanyLogo now resolves branding from config as intended.
Screenshot:
Test setup:
✔️ Checklist