chore(orchestrator): remove cleanup of dependencies. Fixes RHIDP-16038 - #4469
Open
lholmquist wants to merge 1 commit into
Open
chore(orchestrator): remove cleanup of dependencies. Fixes RHIDP-16038#4469lholmquist wants to merge 1 commit into
lholmquist wants to merge 1 commit into
Conversation
lholmquist
requested review from
a team,
christoph-jerolimov,
karthikjeeyar and
lokanandaprabhu
as code owners
August 25, 2026 16:09
Changed Packages
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4469 +/- ##
=======================================
Coverage 61.59% 61.59%
=======================================
Files 2556 2556
Lines 102054 102054
Branches 28576 28576
=======================================
Hits 62856 62856
Misses 38599 38599
Partials 599 599
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up orchestrator plugin dependency graphs after a fresh knip pass (the checked-in reports were stale). Unused packages are dropped, imports that were already in source are declared, and knip reports are regenerated.
Fixes RHIDP-16038.
express-promise-router,yn,vscode-languageserver-types, and unused MUI/RJSF packages@types/uuid,@testing-library/dom)@backstage/catalog-model,@backstage/config,@backstage/types,json-schema,@types/express-serve-static-core,@spotify/prettier-configform-reactonorchestrator-form-widgets(used by theCustomReviewPageexample) and OpenAPI script binaries inorchestrator-commonTest plan
yarn tscinworkspaces/orchestratoryarn build:knip-reportsfor the affected pluginsyarn teston a couple of touched packages (orchestrator-backend,orchestrator-form-widgets) if CI does not already cover themChecklist