fix(scorecard): score first in-window DORA deploys using the prior production deployment - #4474
fix(scorecard): score first in-window DORA deploys using the prior production deployment#4474PatAKnight wants to merge 1 commit into
Conversation
…oduction deployment Signed-off-by: Patrick Knight <pknight@redhat.com>
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
|
🤖 Finished Review · ✅ Success · Started 1:02 PM UTC · Completed 1:17 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $7.80 |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4474 +/- ##
==========================================
+ Coverage 61.59% 61.61% +0.01%
==========================================
Files 2565 2566 +1
Lines 102737 102789 +52
Branches 28822 28834 +12
==========================================
+ Hits 63282 63331 +49
- Misses 38843 38846 +3
Partials 612 612
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ReviewFindingsLow
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| */ | ||
|
|
||
| import { DEFAULT_DEPLOYMENT_FETCH_ITEMS_LIMIT } from '../../github/constants'; | ||
| import { z } from 'zod'; |
There was a problem hiding this comment.
[low] import-ordering
The import from '../../github/constants' is placed before the 'z' import from 'zod'. The established convention across this codebase is to import external/third-party modules before internal/relative imports.
Suggested fix: Move the import { DEFAULT_DEPLOYMENT_FETCH_ITEMS_LIMIT } line below the import { z } from 'zod' line.
fullsend-ai-review
Bot
added
the
ready-for-merge
1 participant
Hey, I just made a Pull Request!
First in-window DORA deploy wasn’t getting scored (lead time skipped PRs into it; CFR skipped the gap before it).
We now load the latest successful prod deploy before the 30-day window and use it as the pair/interval start. No prior deploy, same errors as today. DF/MTTR unchanged. Incident after the last in-window deploy still not counted.
GitHub collectors honor fetchItemsLimit (100) on that lookback so we don’t pull 1000 historical rows.
✔️ Checklist