[bugfix] Fix Slurm job array completion detection - #3707
Open
dingp wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pengfei Ding <9438483+dingp@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes ReFrame’s Slurm job-array completion detection when Slurm reports compact array element IDs (including lists/ranges/steps and percent throttles). It ensures a job array is not treated as complete (and its outputs merged) until the scheduler snapshot accounts for all tasks requested via --array.
Changes:
- Extend Slurm job-id matching to recognize compact array element expressions (e.g.,
123_[1,3-7:2%2]). - Track the requested array task count from the
--arrayoption and keep arrays nonterminal when fewer tasks are observed in scheduler snapshots. - Add unit tests covering array task counting, job-id pattern matching, and polling behavior with incomplete/compact
sacctoutputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
reframe/core/schedulers/slurm.py |
Adds array-expression task counting, broadens Slurm array job-id pattern matching, and prevents premature completion when fewer tasks are observed than requested. |
unittests/test_schedulers.py |
Adds regression tests for array task counting, compact job-id patterns, and polling behavior with incomplete/compact sacct responses. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
Slurm can report a pending throttled array element as 56502501_[1%1]|PENDING. The previous job-ID pattern did not match that form. If sacct simultaneously reported an earlier element as completed, ReFrame could treat the array as complete and merge output before the remaining element ran.
Testing