refactor(preonboarding-requirements) - redo the preonboarding requirements with new API#1114
Merged
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (345 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a988111. Configure here.
jordividaller
force-pushed
the
pbyr-4192-fe-use-new-endpoints
branch
from
July 16, 2026 15:21
a18eb02 to
e71e410
Compare
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
jordividaller
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches onboarding compliance/signing flows and swaps API contracts consumers rely on; risk is moderated because much of the change is generated client surface plus example UI wiring.
Overview
Regenerates the OpenAPI client around a unified pre-onboarding requirements model: list requirements, create documents per requirement slug, and acknowledge / delete acknowledgement via new endpoints (replacing the older document-requirements-only surface). Exports and types rename accordingly (
PreOnboardingRequirement, etc.), with additional unrelated generated routes (WD GPH pay, timesheets, oauth token variant).The example onboarding app turns on the
pre_onboarding_requirementsfeature and updates the review step to render document vs acknowledgement requirements separately. Document flows no longer gate on inline “constraints ack” or passdocument_constraints_ack_atwhen creating documents; blocked dependencies use a shared tooltip that wording depends on requirement type. Acknowledgement requirements callonAcknowledgeRequirementwith lock/pending states from the flows bag, and render HTML descriptions viatransformHtmlToComponents.Generated client bootstrap drops the hardcoded gateway
baseUrlon the default client instance.Reviewed by Cursor Bugbot for commit a18eb02. Bugbot is set up for automated code reviews on this repo. Configure here.