Skip to content

refactor(preonboarding-requirements) - redo the preonboarding requirements with new API#1114

Merged
jordividaller merged 13 commits into
mainfrom
pbyr-4192-fe-use-new-endpoints
Jul 17, 2026
Merged

refactor(preonboarding-requirements) - redo the preonboarding requirements with new API#1114
jordividaller merged 13 commits into
mainfrom
pbyr-4192-fe-use-new-endpoints

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Touches onboarding compliance/signing flows and swaps API contracts consumers rely on; risk is moderated because much of the change is generated client surface plus example UI wiring.

Overview
Regenerates the OpenAPI client around a unified pre-onboarding requirements model: list requirements, create documents per requirement slug, and acknowledge / delete acknowledgement via new endpoints (replacing the older document-requirements-only surface). Exports and types rename accordingly (PreOnboardingRequirement, etc.), with additional unrelated generated routes (WD GPH pay, timesheets, oauth token variant).

The example onboarding app turns on the pre_onboarding_requirements feature and updates the review step to render document vs acknowledgement requirements separately. Document flows no longer gate on inline “constraints ack” or pass document_constraints_ack_at when creating documents; blocked dependencies use a shared tooltip that wording depends on requirement type. Acknowledgement requirements call onAcknowledgeRequirement with lock/pending states from the flows bag, and render HTML descriptions via transformHtmlToComponents.

Generated client bootstrap drops the hardcoded gateway baseUrl on the default client instance.

Reviewed by Cursor Bugbot for commit a18eb02. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 227 kB 226.66 kB +344 B (+0.2%) 🔴
Total (raw) 614.95 kB 612.82 kB +2.13 kB (+0.3%) 🔴
CSS (gzip) 21.45 kB 21.45 kB 0 B (0%) 🟢
CSS (raw) 110.5 kB 110.5 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 227 kB / 250 kB (90.8%)
  • ✅ Total raw: 614.95 kB / 650 kB (94.6%)
  • ✅ CSS gzipped: 21.45 kB / 25 kB (85.8%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.73 kB (0 B (0%))
  3. index.css - 10.73 kB (0 B (0%))
  4. chunk-E7OYLQTJ.js - 6.44 kB (new)
  5. index.js - 6.37 kB (-3 B (-0.0%))
View All Files (345 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.73 kB 0 B (0%)
index.css 10.73 kB 0 B (0%)
chunk-E7OYLQTJ.js 6.44 kB new
index.js 6.37 kB -3 B (-0.0%)
chunk-WLPZEX3T.js 6.15 kB new
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-MIBL6KXN.js 4.86 kB new
chunk-BYHCZCIP.js 4.77 kB new
chunk-K77SVVWR.js 3.89 kB new

✅ Bundle size check passed

Comment thread src/flows/Onboarding/api.ts
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx Outdated
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread example/src/ReviewOnboardingStep.tsx
Comment thread example/src/ReviewOnboardingStep.tsx Outdated
Comment thread example/src/ReviewOnboardingStep.tsx Outdated
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-7p4twrjl7-remotecom.vercel.app
Latest Commit:4022629

Deployed with vercel-action

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-5u4g4cw2z-remotecom.vercel.app
Latest Commit:4022629

Deployed with vercel-action

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a988111. Configure here.

Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
@jordividaller
jordividaller force-pushed the pbyr-4192-fe-use-new-endpoints branch from a18eb02 to e71e410 Compare July 16, 2026 15:21
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 88.48% 88.46% +0.03% 🟢
Statements 87.90% 87.87% +0.03% 🟢
Functions 84.92% 84.84% +0.09% 🟢
Branches 79.87% 79.88% 0%

Detailed Breakdown

Lines Coverage
  • Covered: 3919 / 4429
  • Coverage: 88.48%
  • Change: +0.03% (33 lines)
Statements Coverage
  • Covered: 3980 / 4528
  • Coverage: 87.90%
  • Change: +0.03% (33 statements)
Functions Coverage
  • Covered: 1059 / 1247
  • Coverage: 84.92%
  • Change: +0.09% (7 functions)
Branches Coverage
  • Covered: 2456 / 3075
  • Coverage: 79.87%
  • Change: 0% (11 branches)

✅ Coverage check passed

@gabrielseco gabrielseco changed the title generate new endpoints refactor(preonboarding-requirements) - redo the preonboarding requirements with new API Jul 17, 2026
@jordividaller
jordividaller merged commit 1945779 into main Jul 17, 2026
10 checks passed
@jordividaller
jordividaller deleted the pbyr-4192-fe-use-new-endpoints branch July 17, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants