Skip to content

Retry loadRecording when the dispatch socket closes - #10658

Merged
Domiii merged 5 commits into
mainfrom
dominik/protocol-client-reject-on-close
Sep 1, 2026
Merged

Retry loadRecording when the dispatch socket closes#10658
Domiii merged 5 commits into
mainfrom
dominik/protocol-client-reject-on-close

Conversation

@Domiii

@Domiii Domiii commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Example preprocess could hang when the dispatch WebSocket closed mid-processRecording.
  • Fail on close/error and retry with local withExponentialBackoff.

Problem

  • loadRecording awaited Recording.processRecording on a dispatch socket.
  • Pending commands did not reject on socket close in older @replayio/protocol.
  • A 1006 close left the await pending until Buildkite timed out.

Solution

  • Race command completion against socket close/error.
  • Retry with local withExponentialBackoff (packages/e2e-tests/scripts/exponential-backoff.ts).
  • Bump @replayio/protocol to 0.104.1 (reject-on-close) and refresh yarn.lock.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Domiii Domiii self-assigned this Sep 1, 2026
@Domiii
Domiii requested a review from Andarist September 1, 2026 10:05
@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
devtools Ready Ready Preview Sep 1, 2026 12:06pm UTC

Request Review

Co-authored-by: Cursor <cursoragent@cursor.com>
@Domiii

Domiii commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Replaced the inlined retry loop with the existing scripts/exponential-backoff.ts withExponentialBackoff helper.

@Domiii

Domiii commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

loadRecording now imports withExponentialBackoff from @replayio/protocol@0.104.1 (requires that version published first).

@Domiii
Domiii force-pushed the dominik/protocol-client-reject-on-close branch from 12ee468 to 49e1c84 Compare September 1, 2026 10:41
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@socket-security

socket-security Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​replayio/​protocol@​0.104.1811007890100

View full report

Co-authored-by: Cursor <cursoragent@cursor.com>
@Domiii
Domiii merged commit 60032bd into main Sep 1, 2026
23 checks passed
@Domiii
Domiii deleted the dominik/protocol-client-reject-on-close branch September 1, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants