Skip to content

Fix crash resolving ReScript v12+ binaries #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhammerschmidt merged 1 commit into from
Sep 10, 2026
Merged

Fix crash resolving ReScript v12+ binaries #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#### :bug: Bug fix

- Fix language server crash (`ERR_INVALID_URL`) when resolving platform binaries for ReScript v12+ projects. https://github.com/rescript-lang/rescript-vscode/issues/1181

#### :rocket: New Feature

#### :house: Internal
Expand Down
4 changes: 3 additions & 1 deletion shared/src/findBinary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ export const findBinary = async ({
"..",
`@rescript/${target}/bin.js`,
);
const { binPaths } = await import(url.fileURLToPath(targetPackagePath));
const { binPaths } = await import(
url.pathToFileURL(targetPackagePath).href
Comment thread
fhammerschmidt marked this conversation as resolved.
);

if (binary === "bsc.exe") {
binaryPath = binPaths.bsc_exe;
Expand Down
Loading