fix: do not throw from getUrl on an invalid Host or request target - #2012
Open
freshlogic wants to merge 1 commit into
Open
fix: do not throw from getUrl on an invalid Host or request target#2012freshlogic wants to merge 1 commit into
freshlogic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
Closes:
getUrl()builds a WHATWGURLfrom two client-supplied inputs — theHostheader as theauthority, and the request target. Node's HTTP parser validates neither as a URL, so either
can make
new URL()throw.Router.lookupcallsreq.getUrl().pathnameon every requestbefore any handler runs, nothing on that path catches, and
createServerdefaultshandleUncaughtExceptionstofalse— so one malformed request exits the process.Introduced in 12.0.0 by #1996. 11.1.0 is unaffected —
getUrl()wasurl.parse(this.url),path-only, and never read the
Hostheader.Changes
Guards both
new URL()constructions withURL.canParseand falls back instead of throwing:Hostfalls back to a placeholder authority/and gets a normal 404 rather than killing the server
Tests
Two regression tests in
test/request.test.js. Both confirmed to failagainst unpatched
lib/request.js— the first takes the process down mid-suite, which isthe behaviour being fixed.
Verification
make prepushgreen: 794 nodeunit assertions + 209 mocha.Behaviour against 12.0.0, same server, raw sockets:
Host: foo|barGET http://a:99999/x(validHost)GET http://[::1/xGET a://[GET http://other.example/x(proxy style)OPTIONS *Host