fix(inspector): send workflow history as raw BARE bytes - #5576
Merged
Conversation
|
🚅 Deployed to the actors-pr-5576 environment in rivet-frontend
|
Contributor
Review (updated)The second commit addresses both points raised in my previous pass, plus lands the originally-described
No new correctness, security, or performance issues found in the delta. This is inspector/dev-tooling code behind existing auth, byte-format correctness only, no new I/O or hot paths. |
abcxff
self-requested a review
August 19, 2026 11:24
abcxff
approved these changes
Aug 19, 2026
jog1t
force-pushed
the
fix/inspector-workflow-history-bare-transport
branch
from
August 19, 2026 18:53
90b2056 to
a901236
Compare
jog1t
force-pushed
the
fix/inspector-workflow-history-bare-transport
branch
from
August 19, 2026 19:02
a901236 to
a35d24a
Compare
…ce decode failures
jog1t
force-pushed
the
fix/inspector-workflow-history-bare-transport
branch
from
August 19, 2026 19:17
a35d24a to
df47889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspector Workflow tab failed to render workflow history, reporting
BareError: (byte:3) invalid UTF-8 string.The inspector wire format carries raw BARE workflow-history bytes, but the native bridge ran them through the CBOR compat encoder, which rewrites an
ArrayBufferas["$ArrayBuffer", "<base64>"]. The dashboard then read those CBOR bytes as BARE and failed at byte 3. Only the WebSocket/NAPI path was affected; the HTTP routes already serialized correctly.WorkflowHistoryBytestype so these bytes cannot be handed to the CBOR compat encoder again, making a regression a compile errorInitmessage and an explicitWorkflowHistoryRequest