fix(frontend): theme xyflow controls so workflow visualizer icons are visible - #5577
Conversation
|
🚅 Deployed to the actors-pr-5577 environment in rivet-frontend
|
|
Review Clean, well-motivated fix. Moving the overrides to xyflow's own Nit: leftover duplicate block in The PR's stated goal is to remove "duplicated xyflow override blocks, which had drifted across three stylesheets," and it does clean up the controls/minimap overrides in /* Dark theme for xyflow edges. */
.react-flow__edge-path {
stroke: hsl(var(--muted-foreground));
}This is now redundant: Things that check out
Test coverage No automated tests, which is reasonable for a CSS/theming-only fix — this class of bug (invisible icons) is best caught visually. The Ladle story update is a good, low-cost way to keep this checkable going forward. Nothing blocking here; the leftover |
The zoom, fit-view, and lock controls in the workflow visualizer rendered as blank squares. The buttons kept the library's light-mode background while the icons inherited a near-white foreground colour, so the icons were invisible against them.
<ReactFlow>was never told which colour mode to use, so xyflow stayed in light mode and its own dark palette never applied. The dashboard compensated with ad-hoc property overrides, but those setfillon the button, which never reaches the icon because.react-flow__controls-button svgis more specific and resolvescurrentColorfromcolor. The background override also depended on stylesheet import order, since the library's rule has equal specificity.<ReactFlow>ascolorModeso xyflow applies its own light and dark palettes