Skip to content

Make it so esc saves changes before exiting page when modifying textboxes#1115

Merged
0xfornax merged 3 commits into
rocket-pool:masterfrom
jshufro:jms/keystroke
Jun 23, 2026
Merged

Make it so esc saves changes before exiting page when modifying textboxes#1115
0xfornax merged 3 commits into
rocket-pool:masterfrom
jshufro:jms/keystroke

Conversation

@jshufro

@jshufro jshufro commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

tested quickly and sloppily

@0xfornax

Copy link
Copy Markdown
Member

I'm worried about all the long time users who built the muscle memory that ESC is used when you don't want to save changes.

@jshufro

jshufro commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

I'm worried about all the long time users who built the muscle memory that ESC is used when you don't want to save changes.

I guess I can make it configurable.

@jshufro

jshufro commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

I'm worried about all the long time users who built the muscle memory that ESC is used when you don't want to save changes.

I guess I can make it configurable.

I started doing this and no longer think it's worth it.

Just to be clear, though, the current behavior (before this PR) is that editing a textbox and pressing ESC doesn't just undo the edits to the textbox, it goes to the home page/previous page without showing you that the edits were reverted, which is a terrible UX. Either we need to adopt this PR or change it so the ESC key is no longer a shortcut for 'back' (tab->enter becomes the only way to exit subpages)

As an aside, config.Parameter is ripe for turning into a generic.

@0xfornax 0xfornax merged commit e878e74 into rocket-pool:master Jun 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants