Make foundational command behavior independently provable - #91
Open
rohoswagger wants to merge 2 commits into
Open
Make foundational command behavior independently provable#91rohoswagger wants to merge 2 commits into
rohoswagger wants to merge 2 commits into
Conversation
Exercise amend, commit, parent, and log through real temporary repositories, including linked worktree rendering and hermetic GitHub status responses. The tests cover success, rejection, staging, JSON, and human-output control flow without changing production behavior. Constraint: Tests must not depend on network access or mutate the developer repository. Confidence: high Scope-risk: narrow Reversibility: clean Tested: cargo llvm-cov --all-features --workspace; cargo clippy --all-targets --all-features -- -D warnings; cargo fmt --check Not-tested: Live GitHub rendering; covered hermetically with a fake gh executable.
Add compiled-CLI assertions for nested stack JSON, worktree markers, current-branch rendering, parent stdout, and GitHub-backed PR/draft/CI fields so the coverage tests prove user-visible behavior rather than only successful control flow. Constraint: GitHub behavior remains hermetic through a fake gh executable. Confidence: high Scope-risk: narrow Reversibility: clean Tested: cargo test --test core_cli --all-features log_and_parent_report_the_real_nested_worktree_stack; cargo test --test core_cli --all-features log_renders_pr_draft_ci_and_url_from_github_responses Related: Independent review finding on PR #91.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack managed by
ez.