Make move and checkout refusal paths observable - #97
Open
rohoswagger wants to merge 3 commits into
Open
Conversation
Exercise missing PR and branch navigation, current-branch no-op behavior, self/descendant move rejection, and best-effort PR base repair through compiled CLI commands against real linked worktrees. Clean up the hermetic GitHub shim after use. Constraint: Invalid navigation and cyclic moves must leave refs, worktrees, and stack state unchanged. Confidence: high Scope-risk: narrow Reversibility: clean Tested: cargo test --test switch_worktree_cli --all-features; cargo test --test worktree_mutation_cli --all-features move_; cargo clippy --all-targets --all-features -- -D warnings; cargo fmt --check Not-tested: Successful live GitHub PR-base edit; failure behavior is hermetic and success behavior exists in the broader mutation suite.
Give the move-specific stack-state helpers unique names so PR #97 compiles when combined with delete rollback coverage, which adds equivalent helpers in the same integration test module. Constraint: Independently green PRs must also build in the release aggregate. Confidence: high Scope-risk: narrow Reversibility: clean Tested: focused move PR-base failure test; cargo clippy --test worktree_mutation_cli --all-features -- -D warnings; cargo fmt --check Related: Aggregate integration build after PRs #96 and #97.
Assert both branch tips after the descendant-cycle guard rejects the move, completing the non-mutation contract already checked for stack metadata and worktree ownership. Confidence: high Scope-risk: narrow Reversibility: clean Tested: focused descendant move rejection integration test; cargo fmt --check Related: Independent review finding on PR #97.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack managed by
ez.