Skip to content

Add HyWiki include and exclude major-mode tests #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matsl merged 1 commit into from
Jul 22, 2026
+37 −13
Merged

Add HyWiki include and exclude major-mode tests #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2026-07-22 Mats Lidell <matsl@gnu.org>

* test/hywiki-tests.el (hywiki-tests--potential-buffer-p): New test.
(hywiki-tests--active-in-current-buffer-p): Refactor test, no buffers.

2026-07-21 Bob Weiner <rsw@gnu.org>

* hywiki.el (hywiki-get-entry): Fix return of display-buffer string
Expand Down
45 changes: 32 additions & 13 deletions test/hywiki-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Mats Lidell
;;
;; Orig-Date: 18-May-24 at 23:59:48
;; Last-Mod: 14-Jul-26 at 01:52:39 by Bob Weiner
;; Last-Mod: 21-Jul-26 at 22:30:31 by Mats Lidell
;;
;; SPDX-License-Identifier: GPL-3.0-or-later
;;
Expand Down Expand Up @@ -595,18 +595,16 @@ HyWikiWord reference."

(ert-deftest hywiki-tests--active-in-current-buffer-p ()
"Verify `hywiki-active-in-current-buffer-p'."
(hywiki-tests--preserve-hywiki-mode
(with-current-buffer (find-file-noselect wiki-page)
(should (hywiki-active-in-current-buffer-p))
(hywiki-mode nil)
(should-not (hywiki-active-in-current-buffer-p))
(let ((hywiki-exclude-major-modes (list 'org-mode)))
(should-not (hywiki-active-in-current-buffer-p)))
(hywiki-mode nil)
(mocklet ((hywiki-in-page-p => nil))
(should-not (hywiki-active-in-current-buffer-p)))
(dired-mode)
(should-not (hywiki-active-in-current-buffer-p)))))
(let ((hywiki-mode nil))
(should-not (hywiki-active-in-current-buffer-p)))
(let ((hywiki-mode :pages))
(with-mock
(mock (hywiki-in-page-p) => 'in-page-p)
(should (eq 'in-page-p (hywiki-active-in-current-buffer-p)))))
(let ((hywiki-mode :all))
(with-mock
(mock (hywiki-potential-buffer-p) => 'potential-buffer-p)
(should (eq 'potential-buffer-p (hywiki-active-in-current-buffer-p))))))

(ert-deftest hywiki-tests--directory-get-mod-time ()
"Verify `hywiki-directory-get-mod-time'."
Expand Down Expand Up @@ -2352,6 +2350,27 @@ See helper `hywiki-display-hywiki-test' above for verifying display call."
(beginning-of-line)
(should (looking-at-p (regexp-quote "[[*Header")))))))

(ert-deftest hywiki-tests--potential-buffer-p ()
"Verify include and exclude mode treatment in `hywiki-potential-buffer-p'.
Verifies the behavior controlled by the variables
`hywiki-include-special-modes' and `hywiki-exclude-major-modes'."
(cl-letf (((symbol-function 'minibufferp)
(lambda (&optional _buffer _live) t)))
(should-not (hywiki-potential-buffer-p)))
(with-temp-buffer
;; Regular major-mode
(python-mode)
(should (hywiki-potential-buffer-p))
(let ((hywiki-exclude-major-modes (list 'python-mode)))
(should-not (hywiki-potential-buffer-p))
(let ((hywiki-include-special-modes (list 'python-mode)))
(should (hywiki-potential-buffer-p))))
;; Special major-mode
(dired-mode)
(should-not (hywiki-potential-buffer-p))
(let ((hywiki-include-special-modes (list 'dired-mode)))
(should (hywiki-potential-buffer-p)))))

(provide 'hywiki-tests)

;; This file can't be byte-compiled without the `el-mock' package
Expand Down