Skip to content

Fix predictable API token vulnerability - #2365

Merged
elphizu merged 3 commits into
developfrom
fix/api-token-security
Aug 27, 2026
Merged

elphizu merged 3 commits into
developfrom
fix/api-token-security

Conversation

@elphizu

@elphizu elphizu commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Fixes a security issue where API tokens could be predicted and brute-forced.

Changes

  • Generate secure 64-character random tokens.
  • Reject old 40-character tokens.
  • Expire API tokens after 30 days.
  • Revoke expired tokens.

Note: Existing API users will need to log in again to receive a new token.

Copilot AI balanced review requested due to automatic review settings August 26, 2026 08:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread app/main/controllers/api/RTMediaJsonApiFunctions.php
Copilot AI review requested due to automatic review settings August 26, 2026 09:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@rtBot

rtBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:

  • app/main/controllers/api/RTMediaJsonApi.php
  • app/main/controllers/api/RTMediaJsonApiFunctions.php

The error may be temporary. If the error persists, please contact a human (commit-ID: d8b84fb).

@the-hercules

Copy link
Copy Markdown
Contributor

@elphizu, can you address the Copilot review comments above? If you’ve already addressed them, please reply to/comment on the relevant review explaining the approach you took.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@elphizu
elphizu merged commit db2fa89 into develop Aug 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants