Skip to content

Honor clone freeze keywords for Config and SequenceSet #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

Honor clone freeze keywords for Config and SequenceSet #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/net/imap/config/attr_accessors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ def freeze

private

def initialize_clone(other)
def initialize_clone(other, **kwargs)
super
@data = other.data.clone
@data = other.data.clone(**kwargs)
end

def initialize_dup(other)
Expand Down
5 changes: 3 additions & 2 deletions lib/net/imap/sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1869,8 +1869,9 @@ def remain_frozen(set) frozen? ? set.freeze : set end
def remain_frozen_empty; frozen? ? SequenceSet.empty : SequenceSet.new end

# frozen clones are shallow copied
def initialize_clone(other)
@set_data = other.dup_set_data unless other.frozen?
def initialize_clone(other, freeze: nil)
@set_data = other.dup_set_data unless other.frozen? && freeze != false
freeze_set_data if freeze
super
end

Expand Down