Skip to content

Accept string arguments in SequenceSet delete? #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 2 commits into from
Aug 29, 2026
Merged

Accept string arguments in SequenceSet delete? #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc87b17
Accept string arguments in SequenceSet delete?
OskarEichler Aug 27, 2026
0839035
test: cover string arguments to SequenceSet#delete?
OskarEichler Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/imap/sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,7 +1922,7 @@ def input_try_convert(input)
def number_input?(input)
case input
when *STARS, Integer then true
when String then !input.include?(/[:,]/)
when String then !input.match?(/[:,]/)
end
end

Expand Down
1 change: 1 addition & 0 deletions test/net/imap/test_sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,7 @@ def obj.to_sequence_set; 192_168.001_255 end
set = SequenceSet.new [5..11, 20, 30..40]
# deleting a single-member range
assert_equal SequenceSet[9], set.delete?(9..9)
assert_equal 6, SequenceSet.new(5..10).delete?("6")
end

test "#slice!" do
Expand Down