Handle zero and negative SequenceSet min/max counts - #742
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return an empty SequenceSet for max(0), reject negative min/max counts, and normalize integer-like counts before slicing. max(0) currently slices from -0 and returns the whole set; negative counts produce unrelated slices. Preserve oversized-count and frozen-result behavior.
Reproduction
Verification
SequenceSet#min(count)and#max(count)#460 defines count behavior and 🐛 FixSequenceSet#max(n)whencardinality < n <= size#580 fixes a separate cardinality/duplicate case already present in master.rake teston this isolated branch: 1726 tests, 12598 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications, Ruby 4.0.6 via rbenv. The baseline also passes all 1,726 tests; assertion counts vary slightly across runs.git diff --checkpass. No repository tests, dependencies or workflows were added or modified; focused reproductions live outside the repository under the consumer's no-new-tests policy.6d2ef7a636a1e2449187a83b06ac7a5baa54ead2; the runtime diff from released 0.6.6 is documentation-only before this patch.Compatibility and limits
Intentional correction: negative counts now raise ArgumentError rather than returning a slice. Zero yields an empty set. Omitted/nil/false count behavior and scalar star handling are unchanged. Integer-like counts use the existing SequenceSet to_int coercion convention. Other Ruby/OS versions were not run locally. No production or external IMAP service was used. Local verification does not imply upstream CI approval or comprehensive behavioral coverage.