Skip to content

Initialize SMTP exception messages through the superclass #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −6
Open

Initialize SMTP exception messages through the superclass #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc7dbe4
Initialize SMTP exception messages through the superclass
OskarEichler Aug 27, 2026
781981c
Add regression coverage for initialize smtp exception messages throug…
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lib/net/smtp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,12 @@ module SMTPError
def initialize(response, message: nil)
if response.is_a?(::Net::SMTP::Response)
@response = response
@message = message
super(message || response.message)
else
@response = nil
@message = message || response
super(message || response)
end
end

def message
@message || response.message
end
end

# Represents an SMTP authentication error.
Expand Down
8 changes: 8 additions & 0 deletions test/net/smtp/test_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ def test_default_exception
res = Response.parse("250 omg fatal error")
assert_equal Net::SMTPUnknownError, res.exception_class
end

def test_smtp_exception_uses_standard_exception_message
error = Net::SMTPFatalError.new("original")
replacement = error.exception("replacement")

assert_equal "original", error.to_s
assert_equal "replacement", replacement.message
end
end
end
end